Skip to content

Commit dbbc073

Browse files
committed
Update options project to Svelte 5
1 parent c0fc236 commit dbbc073

File tree

3 files changed

+10
-23
lines changed

3 files changed

+10
-23
lines changed

src/options/Options.svelte

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@
122122
<input
123123
type="checkbox"
124124
bind:checked={options.openInNewTab}
125-
on:change={handleCheckboxChange}
125+
onchange={handleCheckboxChange}
126126
data-option-name="openInNewTab" />
127127
{strings.openInNewTab}
128128
</label>
@@ -133,7 +133,7 @@
133133
<input
134134
type="checkbox"
135135
bind:checked={options.truncate}
136-
on:change={handleCheckboxChange}
136+
onchange={handleCheckboxChange}
137137
data-option-name="truncate" />
138138
{strings.truncate}
139139
</label>
@@ -143,7 +143,7 @@
143143
<input
144144
type="checkbox"
145145
bind:checked={options.tooltips}
146-
on:change={handleCheckboxChange}
146+
onchange={handleCheckboxChange}
147147
data-option-name="tooltips" />
148148
{strings.tooltips}
149149
</label>
@@ -153,7 +153,7 @@
153153
<input
154154
type="checkbox"
155155
bind:checked={options.showRecentlyVisited}
156-
on:change={handleCheckboxChange}
156+
onchange={handleCheckboxChange}
157157
data-option-name="showRecentlyVisited" />
158158
{strings.showRecentlyVisited}
159159
</label>
@@ -169,7 +169,7 @@
169169
name="colorScheme"
170170
value="light"
171171
bind:group={options.colorScheme}
172-
on:change={handleRadioChange} />
172+
onchange={handleRadioChange} />
173173
{strings.colorSchemeLight}
174174
</label>
175175
</div>
@@ -180,7 +180,7 @@
180180
name="colorScheme"
181181
value="dark"
182182
bind:group={options.colorScheme}
183-
on:change={handleRadioChange} />
183+
onchange={handleRadioChange} />
184184
{strings.colorSchemeDark}
185185
</label>
186186
</div>

src/options/main.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1+
import { mount } from 'svelte';
2+
13
import Options from './Options.svelte';
24

35
const target = document.getElementById('app');
46
if (!target) {
57
throw new Error('Missing app element');
68
}
79

8-
new Options({ target });
10+
mount(Options, { target });

src/options/vite.config.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { resolve } from 'path';
22
import { type ViteUserConfig, defineProject, mergeConfig } from 'vitest/config';
33
import { svelte } from '@sveltejs/vite-plugin-svelte';
44
import { svelteTesting } from '@testing-library/svelte/vite';
5-
import { sveltePreprocess } from 'svelte-preprocess';
65
import tsconfigPaths from 'vite-tsconfig-paths';
76
import { developmentConfig } from '../../vite.common-development.config.js';
87
import { getTreetopDistName } from '../../vite.common.config.js';
@@ -12,28 +11,14 @@ const dist = getTreetopDistName();
1211
// https://vitejs.dev/config/
1312
export default defineProject(({ mode }) => {
1413
const commonConfig: ViteUserConfig = {
15-
plugins: [
16-
tsconfigPaths(),
17-
svelte({
18-
preprocess: sveltePreprocess(),
19-
}),
20-
svelteTesting(),
21-
],
14+
plugins: [tsconfigPaths(), svelte(), svelteTesting()],
2215
build: {
2316
outDir: resolve(__dirname, '../../', dist),
2417
rollupOptions: {
2518
input: resolve(__dirname, './options.html'),
2619
},
2720
},
2821
test: {
29-
// Work around onMount not being called when running tests
30-
// https://github.com/vitest-dev/vitest/issues/2834#issuecomment-1439576110
31-
alias: [
32-
{
33-
find: /^svelte$/,
34-
replacement: 'svelte/internal',
35-
},
36-
],
3722
environment: 'jsdom',
3823
restoreMocks: true,
3924
setupFiles: [

0 commit comments

Comments
 (0)