Fixing sigFPE bug

Author: msoos

src/cl_predictors_abs.h

@@ -44,14 +44,6 @@ class Solver;
 
 struct ReduceCommonData
 {
-    double safe_div(double a, double b) {
-        if (b == 0) {
-            assert(a == 0);
-            return 0;
-        }
-        return a/b;
-    }
-
     double   avg_props;
     //double   avg_glue; CANNOT COUNT, ternary has no glue!
     double   avg_uip;

src/constants.h

@@ -24,10 +24,10 @@ THE SOFTWARE.
 
 #include <cstdint>
 #include <cstdlib>
-#include <cstdio>
 #include <iostream>
 #include <random>
 #include <ranges>
+#include <cassert>
 
 using std::cerr;
 using std::exit;
@@ -244,3 +244,12 @@ inline uint32_t rnd_uint(std::mt19937_64& mtrand, const uint32_t maximum_inclusi
     /*cout << "set unsat CL ID here to " << (x) << endl;*/\
     /*assert(false);*/\
     } while (0)
+
+
+inline double safe_div(double a, double b) {
+    if (b == 0) {
+        assert(a == 0);
+        return 0;
+    }
+    return a/b;
+}

src/matrixfinder.cpp

@@ -185,14 +185,6 @@ bool MatrixFinder::find_matrices(bool& matrix_created)
     return solver->okay();
 }
 
-static double safe_div(double a, double b) {
-    if (b == 0) {
-        assert(a == 0);
-        return 0;
-    }
-    return a/b;
-}
-
 uint32_t MatrixFinder::setup_matrices_attach_remaining_cls() {
     if (solver->conf.sampling_vars_set) {
         uint32_t size_at_least = (double)solver->conf.sampling_vars.size()*3;

src/oracle_use.cpp

@@ -278,7 +278,8 @@ bool Solver::oracle_vivif(int fast, bool& backbone_found) {
             << " T: " << std::setprecision(2) << (end_bin_tme - start_bin_time));
 
     verb_print(1, "[oracle-vivif] cache usefulness: "
-            << std::setprecision(0) << std::fixed << (double)oracle.getStats().cache_useful/(double)oracle.getStats().total_cache_lookups*100.0 << "%"
+            << std::setprecision(0) << std::fixed <<
+            safe_div(oracle.getStats().cache_useful, oracle.getStats().total_cache_lookups)*100.0 << "%"
             << std::setprecision(2)
             << " total T: " << std::setprecision(2) << (cpuTime() - start_vivif_time));
     return solver->okay();