fix aura and lwc deploy errors

Author: Mohith Shrivastava

package.json

@@ -1,13 +1,13 @@
 {
   "name": "mo-dx-plugin",
-  "version": "0.2.7",
+  "version": "0.2.8",
   "author": "Mohith Shrivastava",
   "bugs": "https://github.com/ForceProjects/mo-dx-plugin/issues",
   "dependencies": {
     "@oclif/command": "^1.5.8",
     "@oclif/config": "^1.12.6",
     "@oclif/errors": "^1.2.2",
-    "@salesforce/command": "^2.1.3",
+    "@salesforce/command": "^3.0.0",
     "@salesforce/ts-types": "^1.0.1",
     "adm-zip": "^0.4.13",
     "chalk": "^3.0.0",
@@ -23,8 +23,8 @@
     "@salesforce/dev-config": "1.1.4",
     "@types/adm-zip": "^0.4.31",
     "@types/chai": "^4",
-    "@types/fs-extra": "^5.0.3",
-    "@types/jsforce": "1.9.8",
+    "@types/fs-extra": "^8.0.1",
+    "@types/jsforce": "1.9.13",
     "@types/lodash": "^4.14.13",
     "@types/mime-types": "^2.1.0",
     "@types/mocha": "^5",

src/commands/deploy/aura.ts

@@ -148,33 +148,37 @@ export default class AuraDeploy extends SfdxCommand {
       );
     }
 
+     // There is a bug in the JSforce for bulk inserts so executing insert/updates in loop instead of array
+
     // function to update all the AuraDefinition
     async function upsertAuraDefinition(auraDefinitions: AuraDefinition[] , files: string[], bundleId: string) {
-        const auraDefinitionsToCreate: AuraDefinition[] = [];
-        const auraDefinitionsToUpdate: AuraDefinition[] = [];
+        // const auraDefinitionsToCreate: AuraDefinition[] = [];
+        // const auraDefinitionsToUpdate: AuraDefinition[] = [];
         const promiseArray = [];
         fileKey.forEach ( key => {
           const auraDef = auraDefinitions.find(auraDefinition => auraDefinition.DefType === key);
           if (auraDef) {
             const definitionToUpdate = {} as AuraDefinition;
             definitionToUpdate.Id = auraDef.Id;
             definitionToUpdate.Source = files[fileKey.indexOf(auraDef.DefType)];
-            auraDefinitionsToUpdate.push(definitionToUpdate);
+            // auraDefinitionsToUpdate.push(definitionToUpdate);
+            promiseArray.push(conn.tooling.sobject('AuraDefinition').update(definitionToUpdate));
           } else {
             const definitionToInsert = {} as AuraDefinition;
             definitionToInsert.AuraDefinitionBundleId = bundleId;
             definitionToInsert.DefType = key;
             definitionToInsert.Format = getAuraFormat((validFiles[fileKey.indexOf(key)].split('.'))[1]);
             definitionToInsert.Source = files[fileKey.indexOf(key)];
-            auraDefinitionsToCreate.push(definitionToInsert);
+            // auraDefinitionsToCreate.push(definitionToInsert);
+            promiseArray.push(conn.tooling.sobject('AuraDefinition').create(definitionToInsert));
           }
         });
-        if (auraDefinitionsToUpdate.length > 0) {
+        /*if (auraDefinitionsToUpdate.length > 0) {
           promiseArray.push(conn.tooling.sobject('AuraDefinition').update(auraDefinitionsToUpdate));
         }
         if (auraDefinitionsToCreate.length > 0) {
           promiseArray.push(conn.tooling.sobject('AuraDefinition').create(auraDefinitionsToCreate));
-        }
+        }*/
         return Promise.all(promiseArray);
     }
 

src/commands/deploy/lwc.ts

@@ -198,32 +198,34 @@ export default class LWCDeploy extends SfdxCommand {
     }
 
     // function to update all the LightningComponentResource
+    // There is a bug in the JSforce for bulk inserts so executing insert/updates in loop instead of array
     async function upsertLWCDefinition(lwcResources: LightningComponentResource[] , files: string[], bundleId: string) {
-        const lwcResourcesToCreate: LightningComponentResource[] = [];
-        const lwcResourcesToUpdate: LightningComponentResource[] = [];
+        // const lwcResourcesToCreate: LightningComponentResource[] = [];
+        // const lwcResourcesToUpdate: LightningComponentResource[] = [];
         const promiseArray = [];
         validFiles.forEach ( filename => {
           const lwcMatch = lwcResources.find(lwc => lwc.FilePath === getFilepath( _fileOrDirName, filename));
           if (lwcMatch) {
             const lwcResourceToUpdate = {} as LightningComponentResource;
             lwcResourceToUpdate.Id = lwcMatch.Id;
             lwcResourceToUpdate.Source = files[filePath.indexOf(lwcMatch.FilePath)];
-            lwcResourcesToUpdate.push(lwcResourceToUpdate);
+            promiseArray.push(conn.tooling.sobject('LightningComponentResource').update(lwcResourceToUpdate));
           } else {
             const lwcResourceToInsert = {} as LightningComponentResource;
             lwcResourceToInsert.LightningComponentBundleId = bundleId;
             lwcResourceToInsert.FilePath = getFilepath( _fileOrDirName, filename);
             lwcResourceToInsert.Format = (filename.split('.'))[(filename.split('.').length - 1)];
             lwcResourceToInsert.Source = files[filePath.indexOf(getFilepath( _fileOrDirName, filename))];
-            lwcResourcesToCreate.push(lwcResourceToInsert);
+            promiseArray.push(conn.tooling.sobject('LightningComponentResource').create(lwcResourceToInsert));
+            // lwcResourcesToCreate.push(lwcResourceToInsert);
           }
         });
-        if (lwcResourcesToUpdate.length > 0) {
+        /*if (lwcResourcesToUpdate.length > 0) {
           promiseArray.push(conn.tooling.sobject('LightningComponentResource').update(lwcResourcesToUpdate));
         }
         if (lwcResourcesToCreate.length > 0) {
           promiseArray.push(conn.tooling.sobject('LightningComponentResource').create(lwcResourcesToCreate));
-        }
+        }*/
         return Promise.all(promiseArray);
     }