Skip to content

Commit 28efc96

Browse files
mstevebCopilot
andcommitted
Use ntldd to dynamically find and package DLL dependencies
Instead of hardcoding specific DLL names, use ntldd (mingw-w64 tool for finding dependencies) to automatically find all DLL dependencies of jimsh.exe. This ensures all required DLLs are included in the artifact regardless of which extensions are compiled. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent 0bf3299 commit 28efc96

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

.github/workflows/makefile.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,9 @@ jobs:
5656
run: |
5757
cp jimsh.exe jimsh_debug.exe
5858
strip jimsh.exe
59-
7z a jimsh.zip jimsh.exe jimsh_debug.exe /c/msys64/mingw32/bin/{libcrypto-*.dll,libgcc_s_dw2-1.dll,libsqlite3-0.dll,libssl-*.dll,libwinpthread-1.dll,zlib1.dll}
59+
pacman -S --noconfirm mingw-w64-i686-ntldd
60+
ntldd -R jimsh.exe | grep -i "mingw32/bin" | awk '{print $3}' | xargs -I {} cp {} .
61+
7z a jimsh.zip jimsh.exe jimsh_debug.exe *.dll
6062
6163
- name: Upload artifacts
6264
uses: actions/upload-artifact@v4

0 commit comments

Comments
 (0)