mpvpaper considerable log spam

[opticblu]

First, thank you so much for this fork! It's great and really appreciated

I noticed, however that swaylock-plugin is logging what appears to be every single frame decoded, indefinitely. I'm on hyprland with a bit of an unorthodox setup, which is worth noting:

i7-12700K@5.30 GHz/z690/96g DDR5 6400@6200, Archlinux btw 6.6.16-lts normal gcc arch kernel, zfs root on optane, Radeon 6650XT and Alder lake integrated GPU (for VAAPI/AV1) -- stable and well built rig

hyprland, almost always on the git/master branch

Using a 25fps video for mpvpaper lock screen, dual displays, one is 4k@144hz horizontal, secondary is 4k60 vertical orientation, both 1.5x scale (fractional), mpv configured to use Alder Lake iGPU for decoding (low power draw for a screen saver, reliable intel driver stack, reasons)

Anyway, this is what I get when I lock the screen: (zultra is hostname)

Feb 17 01:57:21 zultra systemd[5785]: Started Screen locker for Wayland.
Feb 17 01:57:21 zultra swaylock-plugin[1330180]: Cannot load libcuda.so.1
Feb 17 01:57:21 zultra swaylock-plugin[1330180]: (+) Video --vid=1 (*) (h264 3840x2160 25.000fps)
Feb 17 01:57:21 zultra swaylock-plugin[1330180]: Using hardware decoding (vaapi).
Feb 17 01:57:21 zultra swaylock-plugin[1330180]: [autoconvert] Converting vaapi[nv12] -> vaapi[rgb0]
Feb 17 01:57:21 zultra swaylock-plugin[1330180]: VO: [libmpv] 3840x2160 vaapi[rgb0]
Feb 17 01:57:21 zultra swaylock-plugin[1330180]: V: 00:00:00 / 00:00:30 (0%)
Feb 17 01:57:21 zultra swaylock-plugin[1330180]: V: 00:00:00 / 00:00:30 (1%)
Feb 17 01:57:22 zultra swaylock-plugin[1330180]: V: 00:00:00 / 00:00:30 (2%)
Feb 17 01:57:22 zultra swaylock-plugin[1330180]: V: 00:00:00 / 00:00:30 (3%)
Feb 17 01:57:22 zultra swaylock-plugin[1330180]: V: 00:00:01 / 00:00:30 (3%)
Feb 17 01:57:22 zultra swaylock-plugin[1330180]: V: 00:00:01 / 00:00:30 (4%)
Feb 17 01:57:23 zultra swaylock-plugin[1330180]: V: 00:00:01 / 00:00:30 (5%)
Feb 17 01:57:23 zultra swaylock-plugin[1330180]: V: 00:00:01 / 00:00:30 (6%)
Feb 17 01:57:23 zultra swaylock-plugin[1330180]: V: 00:00:01 / 00:00:30 (7%)
Feb 17 01:57:23 zultra swaylock-plugin[1330180]: V: 00:00:02 / 00:00:30 (7%)
Feb 17 01:57:23 zultra dbus-daemon[5297]: [system] Activating via systemd: service name='net.reactivated.Fprint' unit='fprintd.service' requested by ':1.187' (uid=1000 pid=1330178 comm="/usr/bin/swaylock-plugin -f")
Feb 17 01:57:24 zultra systemd[1]: Starting Fingerprint Authentication Daemon...
Feb 17 01:57:24 zultra swaylock-plugin[1330180]: V: 00:00:02 / 00:00:30 (8%)
Feb 17 01:57:24 zultra dbus-daemon[5297]: [system] Successfully activated service 'net.reactivated.Fprint'
Feb 17 01:57:24 zultra systemd[1]: Started Fingerprint Authentication Daemon.
Feb 17 01:57:24 zultra swaylock-plugin[1330180]: V: 00:00:02 / 00:00:30 (9%)
Feb 17 01:57:24 zultra swaylock-plugin[1330180]: V: 00:00:02 / 00:00:30 (10%)
Feb 17 01:57:24 zultra swaylock-plugin[1330180]: V: 00:00:03 / 00:00:30 (10%)
Feb 17 01:57:24 zultra swaylock-plugin[1330180]: V: 00:00:03 / 00:00:30 (11%)
Feb 17 01:57:25 zultra swaylock-plugin[1330180]: V: 00:00:03 / 00:00:30 (12%)
Feb 17 01:57:25 zultra swaylock-plugin[1330180]: V: 00:00:03 / 00:00:30 (13%)
Feb 17 01:57:25 zultra swaylock-plugin[1330180]: V: 00:00:04 / 00:00:30 (13%)
Feb 17 01:57:25 zultra swaylock-plugin[1330180]: V: 00:00:04 / 00:00:30 (14%)
Feb 17 01:57:26 zultra swaylock-plugin[1330180]: V: 00:00:04 / 00:00:30 (15%)
Feb 17 01:57:26 zultra swaylock-plugin[1330180]: V: 00:00:04 / 00:00:30 (16%)
Feb 17 01:57:26 zultra swaylock-plugin[1330180]: V: 00:00:04 / 00:00:30 (17%)
Feb 17 01:57:26 zultra swaylock-plugin[1330180]: V: 00:00:05 / 00:00:30 (17%)
Feb 17 01:57:27 zultra swaylock-plugin[1330180]: V: 00:00:05 / 00:00:30 (18%)
Feb 17 01:57:27 zultra swaylock-plugin[1330180]: V: 00:00:05 / 00:00:30 (19%)
Feb 17 01:57:27 zultra swaylock-plugin[1330180]: V: 00:00:05 / 00:00:30 (20%)

mpvpaper does not do this on its own outside of swaylock-plugin, so i think it may be specific to swaylock-plugin... but here's the twist that I just remembered as I type: I use systemd-lock-handler (https://sr.ht/~whynothugo/systemd-lock-handler/) to trigger swaylock, so that might be related

Pardon the ultra verbose report, hopefully this gives you enough information

Thanks so much for the great fork, loving it

[mstoeckl]

swaylock-plugin executes all commands using sh -c, so you should be able to use shell redirection in the command string to silence this.

swaylock-plugin --command 'mpvpaper [...] >/dev/null 2>/dev/null'

mpv also has --quiet, --really-quiet, --no-terminal flags that you might be able to pass to mpvpaper using its --mpv-options argument.

I'm not closing this issue yet, because it's possible this can also be fixed if swaylock-plugin stops sharing the standard input file descriptor with its commands (like mpvpaper), which might confuse them.

[opticblu]

Cool, thank you!

[mstoeckl]

I'm not closing this issue yet, because it's possible this can also be fixed if swaylock-plugin stops sharing the standard input file descriptor with its commands (like mpvpaper), which might confuse them.

It looks like using setsid() to detach the command from its controlling terminal will make mpvpaper (and mpv itself) stop detecting the terminal and (hopefully) stop trying to maintain a status line. This fixes the log spam if one runs swaylock-plugin, without the -f flag, directly from a terminal. I've added a commit (1dd15b6) that does this. However, it does not fix the log spam in all cases -- mpv (and mpvpaper), when it does not have a controlling terminal, will write the status line by default to stderr if one of stdin or stdout is a not a tty. (I filed an issue with https://github.com/mpv-player/mpv about this exact behavior, number 13541.)