Vaccine temperature graph displaying more than set max ticks

[wlthomson]

Describe the bug

Temperature graph x-axis is rendering too many ticks.

To reproduce

Steps to reproduce the behavior:

See #3625 (comment).

Expected behaviour

Temperature line and bar graphs to render no more than max specified number of ticks (e.g. 15).

Proposed Solution

TODO.

Version and device info

• App version: v7.0.0-rc10
• Tablet model: N/A.
• OS version: N/A.

Additional context

See #3625 for background.

[wlthomson]

After a bit of digging, looks like this is actually intended behaviour. From the victory docs:

The tickCount prop specifies approximately how many ticks should be drawn on the axis. If an array of ticks is supplied in tickValues or tickFormat, the tickCount prop will be used to downsample the provided array to the specified length. If tickValues are not explicitly provided, this value is used by d3Scale to calculate an approximate number of ticks. d3Scale prioritizes returning "nice" values and evenly spaced ticks over an exact number of ticks. This prop must be given as a positive integer.

Unless the ticks are unreadable, I don't think enforcing an exact number is necessary/desirable. Going to keep this open but put on the backlog for further discussion later.

[josh-griffin]

We limit the number of data points already, so I am curious of the behaviour when we don't specify a tickCount at all 🤔