Skip to content

DOB Defaults #4354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2021
Merged

DOB Defaults #4354

merged 1 commit into from
Aug 12, 2021

Conversation

mark-prins
Copy link
Contributor

Fixes #4350 ?

The date of birth is defaulting to the current date and that was causing issues with the validation for me - strangely, it was validation in the wrong direction: the FormDOBInput was valid, though the data in it was out of sync internally.

It did result in the observed effect though, that the form was invalid even though there was something in the age field and therefore a calculated value in the dob text field.

Change summary

Default the DOB value to blank - if this field is required the validation is handled correctly now, with the validation error shown on form load.

Testing

Steps to reproduce or otherwise test the changes of this PR:

  • Create a patient, enter all required values, except DOB. Enter a value for 'age' : expected result - the OK button should be enabled.

@mark-prins mark-prins merged commit 4359e8e into master Aug 12, 2021
@mark-prins mark-prins deleted the #4350-unable-to-create-patient branch August 12, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Intermittent) 'Save' button doesn't go orange when creating new Patient
2 participants