Program based stocktake option disappears when upgrading from 5.1.1 to 6.X

[kat-ms]

Describe the bug

As reported by @bijaySussol (tracking here for posterity).
One of our clients on 5.1.1 was previously using program functionality - but when upgraded to 6.0.4, had noticed the option to select a program stocktake had disappeared.

mSupply Server Version: 5.04

To reproduce

Steps to reproduce the behaviour:

1. Download mSupply mobile 5.1.1
2. Connect to mSupply Desktop 5.04
3. Set up some programs in Desktop and sync to mobile
4. Try to do a program stocktake
5. Upgrade the app to 6.0.4 (don't uninstall or clear any data)
6. Try to do a program stocktake
7. Option to select a program has disappeared

Expected behaviour

Should still be able to do program stocktakes

Proposed Solution

• Trying to reinitialise tablet from scratch - we suspect that maybe changes related to Refactor supplier requisition & stocktakes to use name_tag  #3135 mean that mobile is looking for programs in a place that doesn't exist after upgrade? Maybe?

Version and device info

• App version: 6.0.X
• Tablet model: Any
• OS version: Any

Additional context

Add any other context about the problem here.

[kat-ms]

After re-initialising the tablet (with v6.0.4) the program option showed up again - which does point to an upgrade/migration issue between 5.1.1 and 6.0.0. Since it's quite an old version of mSupply mobile, probably not a high priority to fix (unless this becomes a big problem for the client)

[josh-griffin]

👋

So I imagine:

• Mobile on some version which doesn't know what a name_tag is.
• Server is upgraded to a version with name_tag records, starts to create them and sync them out.
• Mobile site ignores the name_tag records.
• Mobile is eventually upgraded and starts to use name_tag records, but does not have any.

This is why reinit works.

Usually we solve this problem by having code on the server to generate the records after an upgrade. Specifically, for [name_tag]: https://github.com/sussol/msupply/blob/8193e9046f8c2eb5e4881af6f480d617f408c431/Project/Sources/Methods/message_onUpgradeMobileSite.4dm#L83-L98

So, the intention is after an upgrade the mobile device - mobile creates a [message] record saying it upgraded. So, should be online and complete a sync cycle before having received any name_note records when upgrading 5.1 -> 6.

If this is not the case, then there is a bug somewhere in this process:

• the server is not sending the records
• mobile isn't sending the message it's upgraded
• Mobile is ignoring the records sent