Fix McrouterLogger for OSS

facebook/mcrouter#474

Author: mszabo-wikia

third-party/mcrouter/mcrouter-CMakeLists.txt

@@ -86,6 +86,7 @@ list(APPEND CXX_SOURCES ${files})
 add_definitions(-DNO_LIB_GFLAGS)
 add_definitions(-DLIBMC_FBTRACE_DISABLE)
 add_definitions(-DHAVE_CONFIG_H)
+add_definitions(-DMCROUTER_OSS_BUILD)
 
 include_directories("${CMAKE_SOURCE_DIR}")
 include_directories("${CMAKE_BINARY_DIR}")

third-party/mcrouter/src/CMakeLists.txt

@@ -0,0 +1 @@
+/home/catullus/data/hhvm/third-party/mcrouter/mcrouter-CMakeLists.txt

third-party/mcrouter/src/mcrouter/McrouterLogger.cpp

@@ -162,6 +162,7 @@ bool McrouterLogger::start() {
   } else {
     // If default path is not available and TW backup is enabled, try backup
     // path
+#ifndef MCROUTER_OSS_BUILD
     if (router_.opts().enable_tw_crash_config_backup_path &&
         additionalLogger_) {
       auto backupPath = additionalLogger_->getBackupStatsRootPath();
@@ -181,6 +182,11 @@ bool McrouterLogger::start() {
                    << ", disabling stats logging";
       return false;
     }
+#else
+      LOG(WARNING) << "Can't create or chmod " << router_.opts().stats_root
+                   << ", disabling stats logging";
+      return false;
+#endif
   }
 
   boost::filesystem::path path(statsRoot_);