Propagate transport connection errors

Summary: Allows hq session to propagate quic error.

Reviewed By: mingtaoy, hanidamlaj

Differential Revision: D83672572

fbshipit-source-id: 7dffc982b87cada6bf4a7dab8b606a04a605deb8

Author: abakiaydin

third-party/proxygen/src/proxygen/lib/http/session/HQSession.cpp

@@ -532,9 +532,12 @@ void HQSession::onConnectionError(quic::QuicError code) noexcept {
     }
   }
 
+  sessionDropReason_ = SessionDropReason{.quicError = std::move(code),
+                                         .proxygenError = proxygenErr};
   // force close all streams.
   // close with error won't invoke any connection callback, reentrancy safe
-  dropConnectionSync(std::move(code), proxygenErr);
+  dropConnectionSync(sessionDropReason_->quicError,
+                     sessionDropReason_->proxygenError);
 }
 
 bool HQSession::getCurrentTransportInfo(wangle::TransportInfo* tinfo) {
@@ -840,8 +843,9 @@ void HQSession::dropConnection(const std::string& errorMsg) {
 
 void HQSession::dropConnectionAsync(quic::QuicError errorCode,
                                     ProxygenError proxygenError) {
-  if (!dropInNextLoop_.has_value()) {
-    dropInNextLoop_ = std::make_pair(errorCode, proxygenError);
+  if (!sessionDropReason_.has_value()) {
+    sessionDropReason_ = SessionDropReason{.quicError = std::move(errorCode),
+                                           .proxygenError = proxygenError};
     scheduleLoopCallback(true);
   } else {
     VLOG(4) << "Session already scheduled to be dropped: sess=" << *this;
@@ -1086,8 +1090,9 @@ void HQSession::runLoopCallback() noexcept {
     inLoopCallback_ = false;
   });
 
-  if (dropInNextLoop_.has_value()) {
-    dropConnectionSync(dropInNextLoop_->first, dropInNextLoop_->second);
+  if (sessionDropReason_.has_value()) {
+    dropConnectionSync(sessionDropReason_->quicError,
+                       sessionDropReason_->proxygenError);
     return;
   }
 

third-party/proxygen/src/proxygen/lib/http/session/HQSession.h

@@ -471,6 +471,14 @@ class HQSession
     return sock_.get();
   }
 
+  struct SessionDropReason {
+    quic::QuicError quicError{quic::TransportErrorCode::NO_ERROR};
+    ProxygenError proxygenError{ProxygenError::kErrorNone};
+  };
+  const folly::Optional<SessionDropReason>& getSessionDropReason() const {
+    return sessionDropReason_;
+  }
+
   // Override HTTPSessionBase address getter functions
   const folly::SocketAddress& getLocalAddress() const noexcept override {
     return sock_ && sock_->good() ? sock_->getLocalAddress() : localAddr_;
@@ -945,7 +953,7 @@ class HQSession
   bool started_ : 1;
   bool dropping_ : 1;
   bool inLoopCallback_ : 1;
-  folly::Optional<std::pair<quic::QuicError, ProxygenError>> dropInNextLoop_;
+  folly::Optional<SessionDropReason> sessionDropReason_;
 
 #ifdef _MSC_VER
 #pragma warning(push)