Commit 6f164a0
Migrate external consumers to namespaced MySQL include targets
Summary:
Migrate mysql_raft, squangle, and dbproxy to use fbcode-relative includes
with _namespaced targets instead of short includes with header_namespace.
Changes:
- mysql_raft: Update all source files and BUCK to use _namespaced deps
- squangle/mysql_client/mysql_protocol: Update to _namespaced deps
- dbproxy: Update frontend target to use _namespaced deps
- Expand visibility on _namespaced targets in mysql/server/include to
include external consumers (dbproxy, squangle, mysql_raft)
- Fix duplicate container_utils_namespaced target in sql-common/BUCK
- Convert remaining short includes to fbcode-relative paths in mysql_raft
- Fix mysql_raft autodeps and convert remaining short includes
- Convert sql-common/oci to per-header targets
- Fix autodeps dependency issues for namespaced header targets:
- Break cycle between mysql:namespaced_headers and components/services:namespaced_headers
- Add per-file targets (service_plugin_registry, service_srv_session_bits) instead of aggregate deps
- Remove sql:sql_log and sql_error_main deps from log_builtins to break cycle
- Fix autodeps2 issues in mysql_raft/BUCK and mysql_raft/log/BUCK:
- Add missing _namespaced deps for header includes
- Expand visibility on mysql_mutex_bits_namespaced and my_io_bits_namespaced
- Fix dependency cycle in sys_vars_shared_namespaced:
- Remove unnecessary sql_table.h include from sys_vars_shared.h
- This breaks the cycle: rpc_ddl_precheck_leader -> sys_vars_shared_namespaced -> sql_ddl_main -> rpc_ddl_precheck_leader
This is part of the autodeps migration to standardize MySQL header includes.
Reviewed By: nathan-liyiming
Differential Revision: D92447494
fbshipit-source-id: 7e2b4d1b121fe434aae9535a65a8333718f78ec71 parent 4a21638 commit 6f164a0
2 files changed
Lines changed: 2 additions & 2 deletions
File tree
- third-party/squangle/src/squangle/mysql_client/mysql_protocol
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
11 | 10 | | |
12 | 11 | | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
0 commit comments