Skip to content

Commit 773f486

Browse files
janometa-codesync[bot]
authored andcommitted
Revert D87884192, D87884191, D87884195 due to throwing untrusted types from backend (non-exceptions)
Summary: Backends might return T_EXCEPTION, but provide a non-exception class, violating internal HHVM invariants. Back out "[BE] [thrift-hack][Serialization extension] Add faster Binary protocol implementation to read/write structs" Back out "[BE] [thrift-hack][Serialization extension] Make Binary reader/writer templated on transport type" Back out "[BE][Thrift-hack][Serialization extension] Add Binary reader" Reviewed By: rmakheja Differential Revision: D89458660 fbshipit-source-id: 9058cf630dbecd97ca826045cc8e9e1312525830
1 parent 73ccc95 commit 773f486

5 files changed

Lines changed: 485 additions & 620 deletions

File tree

hphp/hack/hhi/stdlib/builtins_thrift.hhi

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,6 @@ function thrift_protocol_write_binary_struct(
3030
HH\FIXME\MISSING_PARAM_TYPE $request_struct,
3131
): void;
3232
<<__PHPStdLib>>
33-
function thrift_protocol_write_binary_struct_to_string(
34-
HH\FIXME\MISSING_PARAM_TYPE $struct,
35-
): string;
36-
<<__PHPStdLib>>
3733
function thrift_protocol_read_binary(
3834
HH\FIXME\MISSING_PARAM_TYPE $transportobj,
3935
string $obj_typename,
@@ -46,12 +42,6 @@ function thrift_protocol_read_binary_struct(
4642
string $obj_typename,
4743
int $options = 0,
4844
): HH\FIXME\MISSING_RETURN_TYPE;
49-
<<__PHPStdLib>>
50-
function thrift_protocol_read_binary_struct_from_string(
51-
string $buffer,
52-
string $obj_typename,
53-
int $options = 0,
54-
): HH\FIXME\MISSING_RETURN_TYPE;
5545

5646
<<__PHPStdLib>>
5747
function thrift_protocol_set_compact_version(

0 commit comments

Comments
 (0)