WIN-3043 | Set SOCK_CLOEXEC for debugger sockets (facebook#131)

It's possible to configure HHVM access logs to be sent to a subprocess
instead of a file, like so:
```
Log {
	Access {
		* {
			File = |/usr/local/bin/some_processor.sh | tee -a /tmp/hhvm-access.log
		}
	}
}
```
Under the hood, this is backed by a `popen(3)` syscall in
`ClassicWriter`, which ultimately creates a pipe, forks and invokes a
shell. If HHVM is running with the debugger enabled
(`hhvm.debugger.vs_debug_enable=1`), this subprocess also ends up
inheriting the file descriptor backing the listening socket of the
debugger. Things then break when a connected debugger client then
disconnects, as it won't be possible to open a new socket.

So, set `SOCK_CLOEXEC` on these sockets so that they get closed in child
processes.

Author: mszabo-wikia

hphp/runtime/ext/vsdebug/socket_transport.cpp

@@ -23,6 +23,7 @@
 
 #include <pwd.h>
 #include <grp.h>
+#include <sys/socket.h>
 
 namespace HPHP {
 namespace VSDEBUG {
@@ -302,7 +303,7 @@ bool SocketTransport::bindAndListenDomain(std::vector<int>& socketFds) {
   struct sockaddr_un addr;
   std::string socketPath = m_domainSocketPath;
 
-  int sockFd = socket(AF_UNIX, SOCK_STREAM, 0);
+  int sockFd = socket(AF_UNIX, SOCK_STREAM | SOCK_CLOEXEC, 0);
   if (sockFd < 0) {
     VSDebugLogger::Log(
       VSDebugLogger::LogLevelError,
@@ -360,7 +361,7 @@ bool SocketTransport::bindAndListenTCP(
   std::vector<int>& socketFds
 ) {
   int fd = socket(address->ai_family,
-                  address->ai_socktype,
+                  address->ai_socktype | SOCK_CLOEXEC,
                   address->ai_protocol);
 
   if (fd < 0) {