Commit 80100e4
Add isNamed field to Glean Parameter schema
Summary:
## What
Add support for Hack named parameters:
```
function foo(named int $x): void {}
```
The type checker and runtime already support named parameters, behind a flag.
## Why
So users get an accurate and informative CodeHub experience and Glean querying experience.
## How I made this stack
I asked Claude to take inspiration from how we did support for `readonly` parameters, since the representation in our AST for `readonly` modifier and `named` modifier is identical.
Reviewed By: donsbot
Differential Revision: D94913061
fbshipit-source-id: b065125b52cc1b6df7b41a786ebef8be64a8d8491 parent b101600 commit 80100e4
2 files changed
Lines changed: 26 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| 70 | + | |
70 | 71 | | |
71 | 72 | | |
72 | 73 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3523 | 3523 | | |
3524 | 3524 | | |
3525 | 3525 | | |
| 3526 | + | |
| 3527 | + | |
| 3528 | + | |
| 3529 | + | |
| 3530 | + | |
| 3531 | + | |
| 3532 | + | |
| 3533 | + | |
| 3534 | + | |
| 3535 | + | |
| 3536 | + | |
| 3537 | + | |
| 3538 | + | |
| 3539 | + | |
| 3540 | + | |
| 3541 | + | |
| 3542 | + | |
| 3543 | + | |
3526 | 3544 | | |
3527 | 3545 | | |
3528 | 3546 | | |
| |||
3606 | 3624 | | |
3607 | 3625 | | |
3608 | 3626 | | |
| 3627 | + | |
3609 | 3628 | | |
3610 | 3629 | | |
3611 | 3630 | | |
| |||
3620 | 3639 | | |
3621 | 3640 | | |
3622 | 3641 | | |
| 3642 | + | |
3623 | 3643 | | |
3624 | 3644 | | |
3625 | 3645 | | |
3626 | | - | |
| 3646 | + | |
3627 | 3647 | | |
3628 | 3648 | | |
3629 | 3649 | | |
| |||
3646 | 3666 | | |
3647 | 3667 | | |
3648 | 3668 | | |
| 3669 | + | |
| 3670 | + | |
| 3671 | + | |
| 3672 | + | |
3649 | 3673 | | |
3650 | 3674 | | |
3651 | 3675 | | |
| |||
0 commit comments