log deprecated opertions to scuba

Reviewed By: thedavekwon

Differential Revision: D67885587

fbshipit-source-id: aeb1a1d374e81dba97a3d2a3697bd2e1b02b3abc

Author: Mizuchi

third-party/thrift/src/thrift/lib/cpp2/op/detail/ContainerPatch.h

@@ -27,6 +27,7 @@
 #include <thrift/lib/cpp/util/VarintUtils.h>
 #include <thrift/lib/cpp2/Adapter.h>
 #include <thrift/lib/cpp2/op/detail/BasePatch.h>
+#include <thrift/lib/cpp2/patch/detail/Scuba.h>
 
 namespace apache::thrift::op::detail {
 
@@ -127,7 +128,13 @@ class ListPatch : public BaseContainerPatch<Patch, ListPatch<Patch>> {
       return;
     }
 
-    DCHECK(data_.prepend()->empty()) << "Prepend in ListPatch is disallowed.";
+    if (!data_.prepend()->empty()) {
+      auto msg = "Prepend in ListPatch is disallowed.";
+      LOG(DFATAL) << msg;
+      patch::detail::logDeprecatedOperation(
+          "ListPatch::Prepend", folly::pretty_name<T>(), msg);
+    }
+
     v.prepend(*data_.prepend());
     v.appendMulti(*data_.append());
   }

third-party/thrift/src/thrift/lib/cpp2/patch/detail/Scuba.cpp

@@ -0,0 +1,26 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include <thrift/lib/cpp2/patch/detail/Scuba.h>
+
+namespace apache::thrift::patch::detail {
+THRIFT_PLUGGABLE_FUNC_REGISTER(
+    void,
+    logDeprecatedOperation,
+    std::string_view,
+    std::string_view,
+    std::string_view) {}
+} // namespace apache::thrift::patch::detail

third-party/thrift/src/thrift/lib/cpp2/patch/detail/Scuba.h

@@ -0,0 +1,29 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <string_view>
+#include <thrift/lib/cpp2/PluggableFunction.h>
+
+namespace apache::thrift::patch::detail {
+THRIFT_PLUGGABLE_FUNC_DECLARE(
+    void,
+    logDeprecatedOperation,
+    std::string_view operation,
+    std::string_view type,
+    std::string_view message);
+}