Skip to content

Commit a5ea61a

Browse files
committed
Use separate build directories for Rust libraries in dune
Currently these all use default/target, which seems to cause difficult-to-debug race conditions in OSS CI. Strangely, (locks /cargo) is supposed to prevent this given that locks with an absolute path is documented by dune to be a global lock, but it doesn't seem to work as intended.
1 parent f016ebc commit a5ea61a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

hphp/hack/scripts/invoke_cargo.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ if [ -z "${HACK_NO_CARGO_VENDOR}" ]; then
4040
fi
4141

4242
if [ -z "${TARGET_DIR}" ]; then
43-
TARGET_DIR="${HACK_BUILD_ROOT}/target"
43+
TARGET_DIR="${HACK_BUILD_ROOT}/target/$pkg"
4444
fi
4545

4646
if [ -z ${HACKDEBUG+1} ]; then

0 commit comments

Comments
 (0)