Skip to content

Commit ec9b964

Browse files
generatedunixname893464919433493mszabo-wikia
authored andcommitted
Cut unused StreamInterceptorContext.h include from ServerGeneratorStreamBridge.h
Summary: **Commandeer this diff (recommended) or land with accept2ship tag.** *This feature is still in BETA and we are continuously improving it. Your constructive feedback would help improving RACER and highly appreciated.* **This diff was generated by Racer AI agent on behalf of [Steven Huang](https://www.internalfb.com/profile/view/1063344695855087) for T254360333. If the diff quality is poor, consider contacting the user to provide clearer instructions on the task.** This diff resolves post-landing build speed regression using recommendations from diff_doctor. Please reach out to oncall+ads_build_speed_official if you have any feedback for this runbook. - If you are happy with the changes, commandeer it if minor edits are needed. (**we encourage commandeer to get the diff credit**) - If you are not happy with the changes, please comment on the diff with clear actions and send it back to the author. Racer will pick it up and re-generate. - If you really feel the Racer is not helping with this change (alas, some complex changes are hard for AI) feel free to abandon this diff. - **For M10N reviewers:** as you review AI-generated diffs, we ask you to give them the same priority as human-generated diffs, and take action in a timely manner by either accepting, rejecting, or resigning as a reviewer. For diffs that don't meet the quality bar (e.g. code doesn't compile, not readable or introduces functionality regressions), we ask that you use the following hashtags to provide clear signals to improve our tools - `#monlowqualitydiff` `#monwrongreviewerdiff` Removed the heavy include `thrift/lib/cpp2/server/StreamInterceptorContext.h` (4.2M bloat) from ServerGeneratorStreamBridge.h and replaced it with a forward declaration. The class is only used through `std::shared_ptr<StreamInterceptorContext>`, which doesn't require the full definition. This change: - Reduces include bloat by 4.2M (15.0M -> 19.2M) - Reduces includes by 216 (1066 -> 1282) - Improves build speed by reducing compilation dependencies --- > Generated by [RACER](https://www.internalfb.com/wiki/RACER_(Risk-Aware_Code_Editing_and_Refactoring)/), powered by [Confucius](https://www.internalfb.com/wiki/Confucius/Analect/Shared_Analects/Confucius_Code_Assist_(CCA)/) [Session](https://www.internalfb.com/confucius?session_id=e91eb442-03a1-11f1-8abb-573d73acb080&tab=Chat), [Trace](https://www.internalfb.com/confucius?session_id=e91eb442-03a1-11f1-8abb-573d73acb080&tab=Trace) Reviewed By: vitaut Differential Revision: D92555145 fbshipit-source-id: b491237ef43290a1734b01e6e2e222bea7b4aff6
1 parent b31c40c commit ec9b964

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

third-party/thrift/src/thrift/lib/cpp2/async/ServerGeneratorStreamBridge.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,10 @@
3030
#include <thrift/lib/cpp2/async/StreamMessage.h>
3131
#include <thrift/lib/cpp2/async/TwoWayBridge.h>
3232
#include <thrift/lib/cpp2/async/TwoWayBridgeUtil.h>
33-
#include <thrift/lib/cpp2/server/StreamInterceptorContext.h>
3433

3534
namespace apache::thrift::detail {
35+
class StreamInterceptorContext;
36+
3637
namespace test {
3738
class TestProducerCallback;
3839
}

0 commit comments

Comments
 (0)