Skip to content

Commit 86436df

Browse files
authored
Tweak opam files (#99)
* stop running @runtest in polars.opam and add more dependencies to polars-async * add OCaml version constraint
1 parent 78cac74 commit 86436df

4 files changed

Lines changed: 43 additions & 7 deletions

File tree

dune-project

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@
3434
core_kernel
3535
core_unix
3636
dune
37-
ocaml
37+
; ocaml-interop does not yet properly support OCaml 5
38+
(ocaml
39+
(< 5.0.0))
3840
ppx_jane
3941
ppx_typed_fields)
4042
(tags
@@ -44,6 +46,16 @@
4446
(name polars_async)
4547
(synopsis "Async OCaml bindings to the Polars dataframe library")
4648
(description "Async OCaml bindings to the Polars dataframe library")
47-
(depends polars async core)
49+
(depends
50+
(core_bench :with-test)
51+
(expect_test_helpers_core :with-test)
52+
(mdx :with-test)
53+
(ocamlformat :dev)
54+
(odoc :with-doc)
55+
(re2 :with-test)
56+
(shell :with-test)
57+
async
58+
core
59+
polars)
4860
(tags
4961
(data-science polars rust)))

polars.opam

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,11 @@ depends: [
2222
"core_kernel"
2323
"core_unix"
2424
"dune" {>= "3.8"}
25-
"ocaml"
25+
"ocaml" {< "5.0.0"}
2626
"ppx_jane"
2727
"ppx_typed_fields"
2828
]
29+
dev-repo: "git+https://github.com/mt-caret/polars-ocaml.git"
2930
build: [
3031
["dune" "subst"] {dev}
3132
[
@@ -36,11 +37,12 @@ build: [
3637
"-j"
3738
jobs
3839
"@install"
39-
"@runtest" {with-test}
40+
# We do not run the @runtest target, since some of our tests depend on
41+
# polars-async, and this causes opam's CI to complain about missing dependencies
42+
# "@runtest" {with-test}
4043
"@doc" {with-doc}
4144
]
4245
]
43-
dev-repo: "git+https://github.com/mt-caret/polars-ocaml.git"
4446
# 32bit is not supported, and the combination of macos+arm64 is known to not
4547
# work due to issues in DWARF unwinding in OCaml
4648
available: (os = "linux" & (arch = "x86_64" | arch = "arm64")) | (os = "macos" & arch = "x86_64")

polars.opam.template

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,19 @@
1+
build: [
2+
["dune" "subst"] {dev}
3+
[
4+
"dune"
5+
"build"
6+
"-p"
7+
name
8+
"-j"
9+
jobs
10+
"@install"
11+
# We do not run the @runtest target, since some of our tests depend on
12+
# polars-async, and this causes opam's CI to complain about missing dependencies
13+
# "@runtest" {with-test}
14+
"@doc" {with-doc}
15+
]
16+
]
117
# 32bit is not supported, and the combination of macos+arm64 is known to not
218
# work due to issues in DWARF unwinding in OCaml
319
available: (os = "linux" & (arch = "x86_64" | arch = "arm64")) | (os = "macos" & arch = "x86_64")

polars_async.opam

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,16 @@ doc: "https://github.com/mt-caret/polars-ocaml"
1111
bug-reports: "https://github.com/mt-caret/polars-ocaml/issues"
1212
depends: [
1313
"dune" {>= "3.8"}
14-
"polars"
14+
"core_bench" {with-test}
15+
"expect_test_helpers_core" {with-test}
16+
"mdx" {with-test}
17+
"ocamlformat" {dev}
18+
"odoc" {with-doc}
19+
"re2" {with-test}
20+
"shell" {with-test}
1521
"async"
1622
"core"
17-
"odoc" {with-doc}
23+
"polars"
1824
]
1925
build: [
2026
["dune" "subst"] {dev}

0 commit comments

Comments
 (0)