Fixes ToolbarToggleGroup not toggling

jassuncao · mtorromeo · commit a089c7bc1e55 · 2025-10-01T23:04:52.000+02:00
`toggleExpanded ?? undefined` resolves to an expression where toggleExpanded is not called.
Vue's event binding can handle null or undefined values gracefully making the ?? undefined unnecessary.
diff --git a/packages/core/src/components/Toolbar/ToolbarToggleGroup.vue b/packages/core/src/components/Toolbar/ToolbarToggleGroup.vue
@@ -6,7 +6,7 @@
         aria-label="Show Filters"
         :aria-expanded="expanded"
         :aria-haspopup="expanded && isContentPopup"
-        @click="toggleExpanded ?? undefined"
+        @click="toggleExpanded"
       >
         <slot name="icon" />
       </pf-button>

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`aria-label="Show Filters"`
`7`	`7`	`:aria-expanded="expanded"`
`8`	`8`	`:aria-haspopup="expanded && isContentPopup"`
`9`		`- @click="toggleExpanded ?? undefined"`
	`9`	`+ @click="toggleExpanded"`
`10`	`10`	`>`
`11`	`11`	`<slot name="icon" />`
`12`	`12`	`</pf-button>`