Skip to content

Tabs - idSuffix not resolved properly #14

@0x0dr1y

Description

@0x0dr1y

Hey there! I hope you are doing well :)

I noticed that in the current version the idSuffix that is provided by the Tabs component to the Tab component is not properly resolved. Instead of rendering the id, it passes a function which will cause errors when relying on the id. It seems like this only happens when using provide/inject as the id is properly resolved everywhere else.

Essentially it renders id="pf-tab-set-${key}-() => r32.id" instead of id="pf-tab-set-${key}-v-0".

Relevant lines:
https://github.com/mtorromeo/vue-patternfly/blob/master/packages/core/src/components/Tabs/Tab.vue#L105
https://github.com/mtorromeo/vue-patternfly/blob/master/packages/core/src/components/Tabs/Tabs.vue#L144

--
This misbehavior was introduced in 125e80f

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions