Skip to content

Commit 667045f

Browse files
MDL-89075 theme_boost: fix anchored drawer height collapse
Anchored drawers are content-sized, but .drawercontent declared flex: 1 1 0. A definite zero flex base gives the drawer nothing to derive its height from, so it collapsed to the header. Override flex-basis to auto in the anchored block so the behaviour no longer depends on minification.
1 parent 8307b6d commit 667045f

3 files changed

Lines changed: 18 additions & 0 deletions

File tree

public/theme/boost/scss/moodle/drawer.scss

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,12 @@ $right-drawer-width: 320px;
324324
padding-bottom: $drawer-anchored-header-bottom-gap;
325325
}
326326
}
327+
328+
// The drawer is content-sized here, so the scrollable area must
329+
// contribute its content height instead of a zero flex base.
330+
.drawercontent {
331+
flex-basis: auto;
332+
}
327333
}
328334

329335
.drawer.drawer-left {

public/theme/boost/style/moodle.css

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34757,6 +34757,12 @@ body.drawer-ease {
3475734757
height: auto;
3475834758
padding-bottom: 0.5rem;
3475934759
}
34760+
.pagelayout-standard .drawer.drawer-left .drawercontent,
34761+
.pagelayout-standard .drawer.drawer-right .drawercontent,
34762+
body.limitedwidth .drawer.drawer-left .drawercontent,
34763+
body.limitedwidth .drawer.drawer-right .drawercontent {
34764+
flex-basis: auto;
34765+
}
3476034766
.pagelayout-standard .drawer.drawer-left,
3476134767
body.limitedwidth .drawer.drawer-left {
3476234768
left: auto;

public/theme/classic/style/moodle.css

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32397,6 +32397,12 @@ body.drawer-ease {
3239732397
height: auto;
3239832398
padding-bottom: 0.5rem;
3239932399
}
32400+
.pagelayout-standard .drawer.drawer-left .drawercontent,
32401+
.pagelayout-standard .drawer.drawer-right .drawercontent,
32402+
body.limitedwidth .drawer.drawer-left .drawercontent,
32403+
body.limitedwidth .drawer.drawer-right .drawercontent {
32404+
flex-basis: auto;
32405+
}
3240032406
.pagelayout-standard .drawer.drawer-left,
3240132407
body.limitedwidth .drawer.drawer-left {
3240232408
left: auto;

0 commit comments

Comments
 (0)