Skip to content

Commit 76c62c0

Browse files
MDL-89337 core_course: align course cards and loading placeholders
1 parent 0a9e89c commit 76c62c0

6 files changed

Lines changed: 17 additions & 17 deletions

File tree

public/blocks/myoverview/templates/placeholders.mustache

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@
2424
}}
2525
<div data-region="loading-placeholder-content" aria-hidden="true">
2626
{{#card}}
27-
<div class="card-grid row row-cols-1 row-cols-sm-2 row-cols-md-3 mx-0 flex-nowrap overflow-hidden" style="height: 13rem">
28-
<div class="col d-flex px-1">{{> core_course/placeholder-course }}</div>
29-
<div class="col d-flex px-1">{{> core_course/placeholder-course }}</div>
30-
<div class="col d-flex px-1">{{> core_course/placeholder-course }}</div>
27+
<div class="card-grid row gx-2 row-cols-1 row-cols-sm-2 row-cols-md-3 flex-nowrap overflow-hidden" style="height: 13rem">
28+
<div class="col">{{> core_course/placeholder-course }}</div>
29+
<div class="col">{{> core_course/placeholder-course }}</div>
30+
<div class="col">{{> core_course/placeholder-course }}</div>
3131
</div>
3232
{{/card}}
3333
{{#list}}

public/blocks/recentlyaccessedcourses/templates/recentlyaccessedcourses-view.mustache

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
}}
2626
<div id="recentlyaccessedcourses-view-{{uniqid}}" data-region="recentlyaccessedcourses-view">
2727
<div data-region="loading-placeholder">
28-
<div class="card-grid mx-0 mt-5 row row-cols-1 row-cols-sm-2 row-cols-md-3 flex-nowrap overflow-hidden" style="height: 13.05rem">
29-
<div class="col p-0">{{> core_course/placeholder-course }}</div>
30-
<div class="col p-0">{{> core_course/placeholder-course }}</div>
31-
<div class="col p-0">{{> core_course/placeholder-course }}</div>
28+
<div class="card-grid row gx-2 mt-5 row-cols-1 row-cols-sm-2 row-cols-md-3 flex-nowrap overflow-hidden" style="height: 13.05rem">
29+
<div class="col">{{> core_course/placeholder-course }}</div>
30+
<div class="col">{{> core_course/placeholder-course }}</div>
31+
<div class="col">{{> core_course/placeholder-course }}</div>
3232
</div>
3333
</div>
3434
<div class="hidden" data-region="view-content">
@@ -37,7 +37,7 @@
3737
{{> core/paged_content_paging_bar }}
3838
</div>
3939
{{/pagingbar}}
40-
<div class="card-carousel mx-0 justify-content-center flex-nowrap overflow-hidden" data-region="card-deck" role="list">
40+
<div class="card-carousel mx-0 gap-2 justify-content-center flex-nowrap overflow-hidden" data-region="card-deck" role="list">
4141
{{#courses}}
4242
{{> core_course/coursecard }}
4343
{{/courses}}

public/blocks/starredcourses/templates/view.mustache

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,10 @@
2929
data-nocoursesimg="{{nocoursesimg}}">
3030
<div data-region="starred-courses-view-content">
3131
<div data-region="starred-courses-loading-placeholder">
32-
<div class="card-grid mx-0 row row-cols-1 row-cols-sm-2 row-cols-lg-3 flex-nowrap overflow-hidden" style="height: 11.1rem">
33-
<div class="col p-0">{{> core_course/placeholder-course }}</div>
34-
<div class="col p-0">{{> core_course/placeholder-course }}</div>
35-
<div class="col p-0">{{> core_course/placeholder-course }}</div>
32+
<div class="card-grid row gx-2 row-cols-1 row-cols-sm-2 row-cols-lg-3 flex-nowrap overflow-hidden" style="height: 11.1rem">
33+
<div class="col">{{> core_course/placeholder-course }}</div>
34+
<div class="col">{{> core_course/placeholder-course }}</div>
35+
<div class="col">{{> core_course/placeholder-course }}</div>
3636
</div>
3737
</div>
3838
</div>

public/course/templates/coursecard.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
]
3535
}
3636
}}
37-
<div class="card course-card mx-1" role="listitem"
37+
<div class="card course-card" role="listitem"
3838
data-region="course-content"
3939
data-course-id="{{{id}}}">
4040
<a href="{{viewurl}}" tabindex="-1">

public/course/templates/coursecards.mustache

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@
3535
}
3636
}}
3737

38-
<div class="card-grid mx-0 row row-cols-1 row-cols-sm-2 row-cols-lg-3 {{$classes}}{{/classes}}" data-region="card-deck" role="list">
38+
<div class="card-grid row gx-2 row-cols-1 row-cols-sm-2 row-cols-lg-3 {{$classes}}{{/classes}}" data-region="card-deck" role="list">
3939
{{#courses}}
40-
<div class="col d-flex px-0 mb-2">
40+
<div class="col d-flex mb-2">
4141
{{> core_course/coursecard }}
4242
</div>
4343
{{/courses}}

public/course/templates/placeholder-course.mustache

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
Example context (json):
2323
{}
2424
}}
25-
<div class="card border-0 px-1">
25+
<div class="card border-0">
2626
<div class="card-img-top bg-pulse-grey w-100" style="height: 7rem">
2727
</div>
2828
<div class="card-body pe-1 course-info-container">

0 commit comments

Comments
 (0)