MDL-88314 aiplacement_editor: Strip think tags from AI-generated text

Author: muhammadarnaldo

public/ai/placement/editor/classes/external/generate_text.php

@@ -91,10 +91,14 @@ public static function execute(
         // Send the action to the AI manager.
         $manager = \core\di::get(\core_ai\manager::class);
         $response = $manager->process_action($action);
+        $generatedcontent = $response->get_response_data()['generatedcontent'] ?? '';
+        // Strip <think>...</think> reasoning blocks emitted by some models
+        // (e.g. qwen3-32b) before returning to the client.
+        $generatedcontent = trim(preg_replace('/<think>.*?<\/think>/is', '', $generatedcontent) ?? $generatedcontent);
         // Return the response.
         return [
             'success' => $response->get_success(),
-            'generatedcontent' => $response->get_response_data()['generatedcontent'] ?? '',
+            'generatedcontent' => $generatedcontent,
             'finishreason' => $response->get_response_data()['finishreason'] ?? '',
             'errorcode' => $response->get_errorcode(),
             'error' => $response->get_error(),
@@ -128,7 +132,7 @@ public static function execute_returns(): external_function_parameters {
                 VALUE_REQUIRED,
             ),
             'generatedcontent' => new external_value(
-                PARAM_TEXT,
+                PARAM_RAW,
                 'The text generated by AI.',
                 VALUE_DEFAULT,
             ),

public/ai/placement/editor/tests/external/generate_text_test.php

@@ -25,6 +25,50 @@
  * @covers     \aiplacement_editor\external\generate_text
  */
 final class generate_text_test extends \advanced_testcase {
+    /**
+     * Test generate_text webservice with think tags in the response.
+     */
+    public function test_execute_with_think_tags(): void {
+        $this->resetAfterTest();
+        set_config('enabled', 1, 'aiplacement_editor');
+        $this->setAdminUser();
+
+        $context = \core\context\system::instance();
+
+        $generatedcontent = '<think>Some internal reasoning.</think>The actual response.';
+
+        $response = new \core_ai\aiactions\responses\response_generate_text(success: true);
+        $response->set_response_data(
+            [
+                'generatedcontent' => $generatedcontent,
+                'finishreason' => 'stop',
+            ]
+        );
+
+        $mockmanager = $this->createMock(\core_ai\manager::class);
+        $mockmanager->method('process_action')->willReturn($response);
+        $mockmanager->method('is_action_available')->willReturn(true);
+        $mockmanager->method('is_action_enabled')->willReturn(true);
+        $mockmanager->method('is_action_enabled_in_context')->willReturn(true);
+        \core\di::set(\core_ai\manager::class, function () use ($mockmanager) {
+            return $mockmanager;
+        });
+
+        $_POST['sesskey'] = sesskey();
+        $params = [
+            'contextid' => $context->id,
+            'prompttext' => 'Say hello.',
+        ];
+
+        $result = \core_external\external_api::call_external_function(
+            'aiplacement_editor_generate_text',
+            $params,
+        );
+
+        $this->assertFalse($result['error']);
+        $this->assertEquals('The actual response.', $result['data']['generatedcontent']);
+    }
+
     /**
      * Test generate_text webservice.
      */