MDL-88314 core_ai: Strip think tags from AI-generated text

Author: muhammadarnaldo

public/ai/classes/aiactions/responses/response_explain_text.php

@@ -72,6 +72,11 @@ public function set_response_data(array $response): void {
         $this->id = $response['id'] ?? null;
         $this->fingerprint = $response['fingerprint'] ?? null;
         $this->generatedcontent = $response['generatedcontent'] ?? null;
+        if ($this->generatedcontent !== null) {
+            $this->generatedcontent = trim(
+                preg_replace('/<think>.*?<\/think>/is', '', $this->generatedcontent) ?? $this->generatedcontent
+            );
+        }
         $this->finishreason = $response['finishreason'] ?? null;
         $this->prompttokens = $response['prompttokens'] ?? null;
         $this->completiontokens = $response['completiontokens'] ?? null;

public/ai/classes/aiactions/responses/response_generate_text.php

@@ -72,6 +72,11 @@ public function set_response_data(array $response): void {
         $this->id = $response['id'] ?? null;
         $this->fingerprint = $response['fingerprint'] ?? null;
         $this->generatedcontent = $response['generatedcontent'] ?? null;
+        if ($this->generatedcontent !== null) {
+            $this->generatedcontent = trim(
+                preg_replace('/<think>.*?<\/think>/is', '', $this->generatedcontent) ?? $this->generatedcontent
+            );
+        }
         $this->finishreason = $response['finishreason'] ?? null;
         $this->prompttokens = $response['prompttokens'] ?? null;
         $this->completiontokens = $response['completiontokens'] ?? null;

public/ai/classes/aiactions/responses/response_summarise_text.php

@@ -72,6 +72,11 @@ public function set_response_data(array $response): void {
         $this->id = $response['id'] ?? null;
         $this->fingerprint = $response['fingerprint'] ?? null;
         $this->generatedcontent = $response['generatedcontent'] ?? null;
+        if ($this->generatedcontent !== null) {
+            $this->generatedcontent = trim(
+                preg_replace('/<think>.*?<\/think>/is', '', $this->generatedcontent) ?? $this->generatedcontent
+            );
+        }
         $this->finishreason = $response['finishreason'] ?? null;
         $this->prompttokens = $response['prompttokens'] ?? null;
         $this->completiontokens = $response['completiontokens'] ?? null;

public/ai/placement/editor/classes/external/generate_text.php

@@ -128,7 +128,7 @@ public static function execute_returns(): external_function_parameters {
                 VALUE_REQUIRED,
             ),
             'generatedcontent' => new external_value(
-                PARAM_TEXT,
+                PARAM_RAW,
                 'The text generated by AI.',
                 VALUE_DEFAULT,
             ),

public/ai/tests/aiactions/responses/response_explain_text_test.php

@@ -75,4 +75,17 @@ public function test_set_response_data(): void {
         $this->assertEquals($body['prompttokens'], $actionresponse->get_response_data()['prompttokens']);
         $this->assertEquals($body['completiontokens'], $actionresponse->get_response_data()['completiontokens']);
     }
+
+    /**
+     * Test that think tags are stripped from generated content.
+     */
+    public function test_set_response_data_strips_think_tags(): void {
+        $actionresponse = new response_explain_text(success: true);
+        $actionresponse->set_response_data([
+            'generatedcontent' => "<think>Some internal reasoning.\nMultiple lines.</think>The actual response.",
+            'finishreason' => 'stop',
+        ]);
+
+        $this->assertEquals('The actual response.', $actionresponse->get_response_data()['generatedcontent']);
+    }
 }

public/ai/tests/aiactions/responses/response_generate_text_test.php

@@ -75,4 +75,17 @@ public function test_set_response_data(): void {
         $this->assertEquals($body['prompttokens'], $actionresponse->get_response_data()['prompttokens']);
         $this->assertEquals($body['completiontokens'], $actionresponse->get_response_data()['completiontokens']);
     }
+
+    /**
+     * Test that think tags are stripped from generated content.
+     */
+    public function test_set_response_data_strips_think_tags(): void {
+        $actionresponse = new response_generate_text(success: true);
+        $actionresponse->set_response_data([
+            'generatedcontent' => "<think>Some internal reasoning.\nMultiple lines.</think>The actual response.",
+            'finishreason' => 'stop',
+        ]);
+
+        $this->assertEquals('The actual response.', $actionresponse->get_response_data()['generatedcontent']);
+    }
 }

public/ai/tests/aiactions/responses/response_summarise_text_test.php

@@ -75,4 +75,17 @@ public function test_set_response_data(): void {
         $this->assertEquals($body['prompttokens'], $actionresponse->get_response_data()['prompttokens']);
         $this->assertEquals($body['completiontokens'], $actionresponse->get_response_data()['completiontokens']);
     }
+
+    /**
+     * Test that think tags are stripped from generated content.
+     */
+    public function test_set_response_data_strips_think_tags(): void {
+        $actionresponse = new response_summarise_text(success: true);
+        $actionresponse->set_response_data([
+            'generatedcontent' => "<think>Some internal reasoning.\nMultiple lines.</think>The actual response.",
+            'finishreason' => 'stop',
+        ]);
+
+        $this->assertEquals('The actual response.', $actionresponse->get_response_data()['generatedcontent']);
+    }
 }