Skip to content

Commit 83d75ff

Browse files
authored
[code-infra] Improve fixed issue canary comment (#5440)
1 parent 7ffe634 commit 83d75ff

1 file changed

Lines changed: 12 additions & 4 deletions

File tree

.github/workflows/fixed-issue.yml

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ jobs:
3434
subject {
3535
... on PullRequest {
3636
number
37+
headRefOid
3738
merged
3839
mergedAt
3940
}
@@ -43,6 +44,7 @@ jobs:
4344
source {
4445
... on PullRequest {
4546
number
47+
headRefOid
4648
merged
4749
mergedAt
4850
}
@@ -82,6 +84,7 @@ jobs:
8284
if (pr && pr.merged) {
8385
relatedPRs.push({
8486
number: pr.number,
87+
commit: pr.headRefOid,
8588
mergedAt: pr.mergedAt
8689
});
8790
}
@@ -97,10 +100,12 @@ jobs:
97100
}
98101
99102
const prNumber = relatedPRs[0].number;
103+
const commit = relatedPRs[0].commit;
100104
console.log(`Found merged PR #${prNumber} associated with issue #${issue_number}`);
101105
102106
// Set output for the next step
103107
core.setOutput('pr_number', prNumber);
108+
core.setOutput('commit', commit);
104109
core.setOutput('has_pr', 'true');
105110
106111
} catch (error) {
@@ -112,8 +117,9 @@ jobs:
112117
uses: actions/github-script@3a2844b7e9c422d3c10d287c895573f7108da1b3 # v9
113118
with:
114119
script: |
115-
// Get PR number from the previous step's output
116120
const prNumber = '${{ steps.get-prs.outputs.pr_number }}';
121+
const commit = '${{ steps.get-prs.outputs.commit }}';
122+
const shortCommit = commit.slice(0, 7);
117123
const issueNumber = context.payload.issue.number;
118124
119125
// Get issue labels
@@ -127,11 +133,13 @@ jobs:
127133
128134
const commentBody = `This ${typeText} will be available in the next npm release of Base UI.
129135
130-
In the meantime, you can try it out on our Canary release channel:
136+
In the meantime, use the [canary build](https://base-ui.com/react/overview/releases#canary-releases) from [PR #${prNumber}](${context.serverUrl}/${context.repo.owner}/${context.repo.repo}/pull/${prNumber}):
131137
132138
\`\`\`sh
133-
npm i https://pkg.pr.new/@base-ui/react@${prNumber}
134-
\`\`\``;
139+
npm i https://pkg.pr.new/@base-ui/react@${shortCommit}
140+
\`\`\`
141+
142+
This installs a complete package for \`@base-ui/react\` with the ${typeText} included. It is hosted by pkg.pr.new rather than npm, and the URL is available for up to six months.`;
135143
136144
await github.rest.issues.createComment({
137145
owner: context.repo.owner,

0 commit comments

Comments
 (0)