[select][menu] Better handle dynamic and non-string items #1861
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
michaldudak
reviewed
May 7, 2025
atomiks
force-pushed
the
fix/select-dynamic-items-remove
branch
from
459bdd0 to
0845efa
Compare
commit: |
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: atomiks <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: atomiks <[email protected]>
github-actions
bot
added
PR: out-of-date
atomiks
changed the title
Signed-off-by: atomiks <[email protected]>
github-actions
bot
removed
the
PR: out-of-date
atomiks
force-pushed
the
fix/select-dynamic-items-remove
branch
from
20123d4 to
6c48601
Compare
mj12albert
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectedItemTextRef.currentis set when the previous text element gets disconnected, fixing the positioningrestoreFocusprop) to ensure keyboard navigation works when item is removed while menu is openscrollArrowvisibility state changing state of parent component in render by moving it locally