From 8984feacbe2ed755f6d46e1ef44edb727b7f0cef Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Mon, 24 Nov 2025 08:51:27 -0500 Subject: [PATCH 1/2] perf: remove useless object --- .../src/tooltip/positioner/TooltipPositioner.tsx | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/packages/react/src/tooltip/positioner/TooltipPositioner.tsx b/packages/react/src/tooltip/positioner/TooltipPositioner.tsx index f4c7077b73..3ba522f399 100644 --- a/packages/react/src/tooltip/positioner/TooltipPositioner.tsx +++ b/packages/react/src/tooltip/positioner/TooltipPositioner.tsx @@ -50,7 +50,7 @@ export const TooltipPositioner = React.forwardRef(function TooltipPositioner( const instantType = store.useState('instantType'); const transitionStatus = store.useState('transitionStatus'); - const positioning = useAnchorPositioning({ + const positioner = useAnchorPositioning({ anchor, positionMethod, floatingRootContext, @@ -80,19 +80,11 @@ export const TooltipPositioner = React.forwardRef(function TooltipPositioner( role: 'presentation', hidden: !mounted, style: { - ...positioning.positionerStyles, + ...positioner.positionerStyles, ...hiddenStyles, }, }; - }, [open, trackCursorAxis, disableHoverablePopup, mounted, positioning.positionerStyles]); - - const positioner = React.useMemo( - () => ({ - props: defaultProps, - ...positioning, - }), - [defaultProps, positioning], - ); + }, [open, trackCursorAxis, disableHoverablePopup, mounted, positioner.positionerStyles]); const state: TooltipPositioner.State = React.useMemo( () => ({ @@ -124,7 +116,7 @@ export const TooltipPositioner = React.forwardRef(function TooltipPositioner( const element = useRenderElement('div', componentProps, { state, - props: [positioner.props, getDisabledMountTransitionStyles(transitionStatus), elementProps], + props: [defaultProps, getDisabledMountTransitionStyles(transitionStatus), elementProps], ref: [forwardedRef, store.useStateSetter('positionerElement')], stateAttributesMapping: popupStateMapping, }); From 1ab290ec9076697b892f5138a7ebcc24096b11dd Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Mon, 24 Nov 2025 08:53:59 -0500 Subject: [PATCH 2/2] lint --- .../tooltip/positioner/TooltipPositioner.tsx | 26 +++++++++---------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/react/src/tooltip/positioner/TooltipPositioner.tsx b/packages/react/src/tooltip/positioner/TooltipPositioner.tsx index 3ba522f399..721c5aa404 100644 --- a/packages/react/src/tooltip/positioner/TooltipPositioner.tsx +++ b/packages/react/src/tooltip/positioner/TooltipPositioner.tsx @@ -50,7 +50,7 @@ export const TooltipPositioner = React.forwardRef(function TooltipPositioner( const instantType = store.useState('instantType'); const transitionStatus = store.useState('transitionStatus'); - const positioner = useAnchorPositioning({ + const positioning = useAnchorPositioning({ anchor, positionMethod, floatingRootContext, @@ -80,25 +80,25 @@ export const TooltipPositioner = React.forwardRef(function TooltipPositioner( role: 'presentation', hidden: !mounted, style: { - ...positioner.positionerStyles, + ...positioning.positionerStyles, ...hiddenStyles, }, }; - }, [open, trackCursorAxis, disableHoverablePopup, mounted, positioner.positionerStyles]); + }, [open, trackCursorAxis, disableHoverablePopup, mounted, positioning.positionerStyles]); const state: TooltipPositioner.State = React.useMemo( () => ({ open, - side: positioner.side, - align: positioner.align, - anchorHidden: positioner.anchorHidden, + side: positioning.side, + align: positioning.align, + anchorHidden: positioning.anchorHidden, instant: trackCursorAxis !== 'none' ? 'tracking-cursor' : instantType, }), [ open, - positioner.side, - positioner.align, - positioner.anchorHidden, + positioning.side, + positioning.align, + positioning.anchorHidden, trackCursorAxis, instantType, ], @@ -107,11 +107,11 @@ export const TooltipPositioner = React.forwardRef(function TooltipPositioner( const contextValue: TooltipPositionerContext = React.useMemo( () => ({ ...state, - arrowRef: positioner.arrowRef, - arrowStyles: positioner.arrowStyles, - arrowUncentered: positioner.arrowUncentered, + arrowRef: positioning.arrowRef, + arrowStyles: positioning.arrowStyles, + arrowUncentered: positioning.arrowUncentered, }), - [state, positioner.arrowRef, positioner.arrowStyles, positioner.arrowUncentered], + [state, positioning.arrowRef, positioning.arrowStyles, positioning.arrowUncentered], ); const element = useRenderElement('div', componentProps, {