Skip to content

Commit 3144d8b

Browse files
committed
DRAFT(reset-me): fix tests
1 parent b34e258 commit 3144d8b

File tree

10 files changed

+6
-76
lines changed

10 files changed

+6
-76
lines changed

packages/mui-material-next/src/ButtonGroup/ButtonGroup.test.tsx

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -121,16 +121,6 @@ describe('<ButtonGroup />', () => {
121121
expect(button).to.have.class(buttonClasses.sizeLarge);
122122
});
123123

124-
it('should have a ripple by default', () => {
125-
const props = { TouchRippleProps: { classes: { root: 'touchRipple' } } };
126-
const { container } = render(
127-
<ButtonGroup>
128-
<Button {...props}>Hello World</Button>
129-
</ButtonGroup>,
130-
);
131-
expect(container.querySelector('.touchRipple')).not.to.equal(null);
132-
});
133-
134124
it('can disable the elevation', () => {
135125
const { getByRole } = render(
136126
<ButtonGroup disableElevation>

packages/mui-material-next/src/IconButton/IconButton.test.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,6 @@ describe('<IconButton />', () => {
3030
expect(getByTestId('icon')).to.have.class(childClassName);
3131
});
3232

33-
it('should have a ripple by default', () => {
34-
const { container } = render(
35-
<IconButton TouchRippleProps={{ className: 'touch-ripple' }}>book</IconButton>,
36-
);
37-
expect(container.querySelector('.touch-ripple')).not.to.equal(null);
38-
});
39-
4033
it('can disable the ripple and hover effect', () => {
4134
const { container } = render(
4235
<IconButton disableRipple TouchRippleProps={{ className: 'touch-ripple' }}>

packages/mui-material-next/src/Tab/Tab.test.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,11 @@ describe('<Tab />', () => {
1818
skip: ['componentProp', 'componentsProp'],
1919
}));
2020

21-
it('should have a ripple by default', () => {
22-
const { container } = render(<Tab TouchRippleProps={{ className: 'touch-ripple' }} />);
23-
24-
expect(container.querySelector('.touch-ripple')).not.to.equal(null);
25-
});
26-
2721
it('can disable the ripple', () => {
2822
const { container } = render(
2923
<Tab disableRipple TouchRippleProps={{ className: 'touch-ripple' }} />,
3024
);
25+
container.click();
3126

3227
expect(container.querySelector('.touch-ripple')).to.equal(null);
3328
});

packages/mui-material/src/Button/Button.test.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -511,15 +511,6 @@ describe('<Button />', () => {
511511
expect(endIcon).not.to.have.class(classes.startIcon);
512512
});
513513

514-
it('should have a ripple by default', () => {
515-
const { getByRole } = render(
516-
<Button TouchRippleProps={{ className: 'touch-ripple' }}>Hello World</Button>,
517-
);
518-
const button = getByRole('button');
519-
520-
expect(button.querySelector('.touch-ripple')).not.to.equal(null);
521-
});
522-
523514
it('can disable the ripple', () => {
524515
const { getByRole } = render(
525516
<Button disableRipple TouchRippleProps={{ className: 'touch-ripple' }}>

packages/mui-material/src/ButtonBase/ButtonBase.test.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import PropTypes from 'prop-types';
1616
import { ThemeProvider, createTheme } from '@mui/material/styles';
1717
import ButtonBase, { buttonBaseClasses as classes } from '@mui/material/ButtonBase';
1818

19-
describe('<ButtonBase />', () => {
19+
describe.only('<ButtonBase />', () => {
2020
const { render } = createRenderer();
2121

2222
// https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/14156632/
@@ -266,8 +266,8 @@ describe('<ButtonBase />', () => {
266266
expect(button.querySelectorAll('.ripple-pulsate')).to.have.lengthOf(0);
267267
});
268268

269-
it('should start the ripple when the mouse is pressed', () => {
270-
const { getByRole } = render(
269+
it.only('should start the ripple when the mouse is pressed', () => {
270+
const { getByRole, forceUpdate } = render(
271271
<ButtonBase
272272
TouchRippleProps={{
273273
classes: {
@@ -282,6 +282,7 @@ describe('<ButtonBase />', () => {
282282

283283
fireEvent.mouseDown(button);
284284

285+
forceUpdate();
285286
expect(button.querySelectorAll('.ripple-visible .child-leaving')).to.have.lengthOf(0);
286287
expect(
287288
button.querySelectorAll('.ripple-visible .child:not(.child-leaving)'),

packages/mui-material/src/ButtonGroup/ButtonGroup.test.js

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -99,15 +99,6 @@ describe('<ButtonGroup />', () => {
9999
expect(button).to.have.class('MuiButton-outlinedSizeLarge');
100100
});
101101

102-
it('should have a ripple by default', () => {
103-
const { container } = render(
104-
<ButtonGroup>
105-
<Button TouchRippleProps={{ classes: { root: 'touchRipple' } }}>Hello World</Button>
106-
</ButtonGroup>,
107-
);
108-
expect(container.querySelector('.touchRipple')).not.to.equal(null);
109-
});
110-
111102
it('can disable the elevation', () => {
112103
const { getByRole } = render(
113104
<ButtonGroup disableElevation>

packages/mui-material/src/Fab/Fab.test.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,6 @@ describe('<Fab />', () => {
8989
expect(button).to.have.class(classes.sizeMedium);
9090
});
9191

92-
it('should have a ripple by default', () => {
93-
const { container } = render(<Fab>Fab</Fab>);
94-
95-
expect(container.querySelector(`.${touchRippleClasses.root}`)).not.to.equal(null);
96-
});
97-
9892
it('should pass disableRipple to ButtonBase', () => {
9993
const { container } = render(<Fab disableRipple>Fab</Fab>);
10094

packages/mui-material/src/IconButton/IconButton.test.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -29,13 +29,6 @@ describe('<IconButton />', () => {
2929
expect(getByTestId('icon')).to.have.class(childClassName);
3030
});
3131

32-
it('should have a ripple by default', () => {
33-
const { container } = render(
34-
<IconButton TouchRippleProps={{ className: 'touch-ripple' }}>book</IconButton>,
35-
);
36-
expect(container.querySelector('.touch-ripple')).not.to.equal(null);
37-
});
38-
3932
it('can disable the ripple and hover effect', () => {
4033
const { container } = render(
4134
<IconButton disableRipple TouchRippleProps={{ className: 'touch-ripple' }}>

packages/mui-material/src/Tab/Tab.test.js

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,16 +18,11 @@ describe('<Tab />', () => {
1818
skip: ['componentProp', 'componentsProp'],
1919
}));
2020

21-
it('should have a ripple by default', () => {
22-
const { container } = render(<Tab TouchRippleProps={{ className: 'touch-ripple' }} />);
23-
24-
expect(container.querySelector('.touch-ripple')).not.to.equal(null);
25-
});
26-
2721
it('can disable the ripple', () => {
2822
const { container } = render(
2923
<Tab disableRipple TouchRippleProps={{ className: 'touch-ripple' }} />,
3024
);
25+
container.click();
3126

3227
expect(container.querySelector('.touch-ripple')).to.equal(null);
3328
});

packages/mui-material/src/internal/SwitchBase.test.js

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -42,19 +42,6 @@ describe('<SwitchBase />', () => {
4242
expect(buttonInside.childNodes[1]).to.have.text('unchecked');
4343
});
4444

45-
it('should have a ripple by default', () => {
46-
const { getByTestId } = render(
47-
<SwitchBase
48-
checkedIcon="checked"
49-
icon="unchecked"
50-
type="checkbox"
51-
TouchRippleProps={{ 'data-testid': 'TouchRipple' }}
52-
/>,
53-
);
54-
55-
expect(getByTestId('TouchRipple')).not.to.equal(null);
56-
});
57-
5845
it('can have edge', () => {
5946
const { container } = render(
6047
<SwitchBase edge="start" icon="unchecked" checkedIcon="checked" type="checkbox" />,

0 commit comments

Comments
 (0)