[system] Refactor getThemeValue to streamline propToStyleFunction mapping#48640
Open
sai6855 wants to merge 2 commits into
Open
[system] Refactor getThemeValue to streamline propToStyleFunction mapping#48640sai6855 wants to merge 2 commits into
sai6855 wants to merge 2 commits into
Conversation
Deploy previewhttps://deploy-preview-48640--material-ui.netlify.app/ Bundle size
Check out the code infra dashboard for more information about this PR. |
sai6855
changed the title
sai6855
added
scope: system
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies how getThemeValue builds the propToStyleFunction lookup by removing the redundant filterPropsMapping intermediate object and deriving everything directly from the existing styleFunctionMapping. This keeps the mapping source-of-truth in one place while preserving the same runtime behavior.
Changes:
- Remove the local
filterPropsMappingobject that duplicatedstyleFunctionMappingdata. - Build
propToStyleFunctionby iteratingstyleFunctionMappingand reading each style function’sfilterProps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the way style function mappings are handled in
getThemeValue.jsby removing the redundantfilterPropsMappingobject and directly utilizing thestyleFunctionMappingobject