Skip to content

[docs-infra] Fix Material UI docs links in code-infra-dashboard PR comment - #1770

Merged
brijeshb42 merged 5 commits into
mui:masterfrom
ZeeshanTamboli:fix-netlify-material-ui-docs-links
Aug 17, 2026
Merged

[docs-infra] Fix Material UI docs links in code-infra-dashboard PR comment#1770
brijeshb42 merged 5 commits into
mui:masterfrom
ZeeshanTamboli:fix-netlify-material-ui-docs-links

Conversation

@ZeeshanTamboli

@ZeeshanTamboli ZeeshanTamboli commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

I noticed that the code-infra-dashboard comment in docs related PRs of Material UI points to wrong doc pages.

For example in a recent PR: mui/material-ui#48939 (comment) points to https://deploy-preview-48939--material-ui.netlify.app/material-ui/components/tabs whereas it should link to https://deploy-preview-48939--material-ui.netlify.app/material-ui/react-tabs/

Code was generated by Codex. But the code logic has been verified by me.

@code-infra-dashboard

code-infra-dashboard Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Deploy preview

https://deploy-preview-1770--mui-internal.netlify.app/
QR code for https://deploy-preview-1770--mui-internal.netlify.app/

Bundle size

Total Size Change: 0B(0.00%) - Total Gzip Change: 0B(0.00%)
Files: 69 total (0 added, 0 removed, 0 changed)

Show details for 69 more bundles

@mui/internal-docs-infra/abstractCreateDemo parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/abstractCreateDemoClient parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/abstractCreateStream parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/abstractCreateTypes parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/ChunkProvider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/cli parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/CodeControllerContext parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/CodeExternalsContext parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/CodeHighlighter parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/CodeHighlighter/errors parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/CodeHighlighter/types parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/CodeProvider parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/CoordinatedLazy parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/CoordinatedLazy/types parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/createDemoData parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/createDemoData/types parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/createSitemap parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/createSitemap/types parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useCode parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useCodeWindow parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useCoordinated parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useCopier parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useCrossTabState parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useDemo parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useDemoController parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useErrors parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useLocalStorageState parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/usePreference parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useScrollAnchor parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useSearch parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useSearch/types parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useStream parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useStream/types parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useType parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useTypes parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/useUrlHashState parsed: 0B(0.00%) gzip: 0B(0.00%)
@mui/internal-docs-infra/withDocsInfra parsed: 0B(0.00%) gzip: 0B(0.00%)
addLineGutters parsed: 0B(0.00%) gzip: 0B(0.00%)
BuildEngine parsed: 0B(0.00%) gzip: 0B(0.00%)
CodeHighlighterChunk parsed: 0B(0.00%) gzip: 0B(0.00%)
CodeHighlighterClient parsed: 0B(0.00%) gzip: 0B(0.00%)
CodeInitialSourceLoader parsed: 0B(0.00%) gzip: 0B(0.00%)
CodeSourceLoader parsed: 0B(0.00%) gzip: 0B(0.00%)
compileCssWithPostcss parsed: 0B(0.00%) gzip: 0B(0.00%)
createFrame parsed: 0B(0.00%) gzip: 0B(0.00%)
createParseSourceWorkerClient parsed: 0B(0.00%) gzip: 0B(0.00%)
EditingEngine parsed: 0B(0.00%) gzip: 0B(0.00%)
embedTransforms parsed: 0B(0.00%) gzip: 0B(0.00%)
enhanceCodeEmphasis parsed: 0B(0.00%) gzip: 0B(0.00%)
findExpandingRanges parsed: 0B(0.00%) gzip: 0B(0.00%)
getHastTextContent parsed: 0B(0.00%) gzip: 0B(0.00%)
grammarLoaders parsed: 0B(0.00%) gzip: 0B(0.00%)
grammars parsed: 0B(0.00%) gzip: 0B(0.00%)
isFrameSpan parsed: 0B(0.00%) gzip: 0B(0.00%)
loadIsomorphicCodeVariant parsed: 0B(0.00%) gzip: 0B(0.00%)
parseSource parsed: 0B(0.00%) gzip: 0B(0.00%)
rolldown-runtime parsed: 0B(0.00%) gzip: 0B(0.00%)
source.css parsed: 0B(0.00%) gzip: 0B(0.00%)
source.js parsed: 0B(0.00%) gzip: 0B(0.00%)
source.json parsed: 0B(0.00%) gzip: 0B(0.00%)
source.mdx parsed: 0B(0.00%) gzip: 0B(0.00%)
source.shell parsed: 0B(0.00%) gzip: 0B(0.00%)
source.ts parsed: 0B(0.00%) gzip: 0B(0.00%)
source.tsx parsed: 0B(0.00%) gzip: 0B(0.00%)
source.yaml parsed: 0B(0.00%) gzip: 0B(0.00%)
text.html.basic parsed: 0B(0.00%) gzip: 0B(0.00%)
text.md parsed: 0B(0.00%) gzip: 0B(0.00%)
TransformEngine parsed: 0B(0.00%) gzip: 0B(0.00%)
transpileSource parsed: 0B(0.00%) gzip: 0B(0.00%)

Details of bundle changes

Performance

Total duration: 18.17 ms +0.42 ms(+2.4%) | Renders: 5 (+0) | Paint: 63.50 ms -7.08 ms(-10.0%)

Test Duration Renders
Counter click (interaction only) 2.08 ms -0.08 ms(-3.5%) 1 (+0)
Counter click 4.16 ms -0.06 ms(-1.5%) 2 (+0)

5 tests within noise — details

Metric alarms

Test Metric Change
Counter click (interaction only) bench:paint#clicked 🔺 +8.09 ms
Counter click bench:paint 🔺 +3.51 ms

Check out the code infra dashboard for more information about this PR.

@ZeeshanTamboli

ZeeshanTamboli commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

@brijeshb42 @Janpot Tagging for review.

@ZeeshanTamboli
ZeeshanTamboli marked this pull request as ready for review August 10, 2026 12:55
@ZeeshanTamboli ZeeshanTamboli changed the title Fix Material UI docs links in code-infra-dashboard PR comment [docs-infra] Fix Material UI docs links in code-infra-dashboard PR comment Aug 10, 2026
@zannager zannager added the scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305). label Aug 11, 2026
@zannager
zannager requested a review from Janpot August 11, 2026 12:37
brijeshb42
brijeshb42 reviewed Aug 17, 2026
View reviewed changes
Comment thread apps/code-infra-dashboard/src/lib/ciReports/formatMaterialUiDocPath.ts Outdated
@ZeeshanTamboli

ZeeshanTamboli commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@brijeshb42 You can merge and release. I don't have access to merge in this repo.

Janpot
Janpot approved these changes Aug 17, 2026
View reviewed changes
Comment thread apps/code-infra-dashboard/src/lib/ciReports/formatMaterialUiDocPath.ts
const DOCS_DATA_PREFIX = 'docs/data/';
const MATERIAL_UI_COMPONENTS_PREFIX = 'material/components/';
const MATERIAL_UI_PREFIX = 'material/';
const SUPPORTED_DOC_FILE_EXTENSIONS = ['.md', '.mdx', '.js', '.jsx', '.ts', '.tsx', '.json'];

@Janpot Janpot Aug 17, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could make this a set as well and do the check with

SUPPORTED_DOC_FILE_EXTENSIONS.has(path.extname(theFilePath))

to avoid the O(n) complexity. It's not that critical for this use-case though.

@brijeshb42
brijeshb42 enabled auto-merge (squash) August 17, 2026 10:24
@brijeshb42
brijeshb42 merged commit c12de26 into mui:master Aug 17, 2026
16 checks passed
@ZeeshanTamboli
ZeeshanTamboli deleted the fix-netlify-material-ui-docs-links branch August 17, 2026 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Janpot Janpot Janpot approved these changes
@brijeshb42 brijeshb42 Awaiting requested review from brijeshb42

Assignees

No one assigned

Labels

scope: docs-infra Involves the docs-infra product (https://www.notion.so/mui-org/b9f676062eb94747b6768209f7751305).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ZeeshanTamboli @brijeshb42 @Janpot @zannager