Skip to content

[DataGridPro] Fix expandable rows detail content height updates #17394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 23, 2025
Merged

[DataGridPro] Fix expandable rows detail content height updates #17394

merged 5 commits into from
Apr 23, 2025

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Apr 16, 2025 •
edited
Loading

Fixes #17358

Not visible in our demos because we never recreate rows.

@arminmeh arminmeh added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user feature: Master-detail Related to the data grid Master-detail feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Apr 16, 2025
@arminmeh arminmeh requested a review from a team April 16, 2025 09:19
@arminmeh arminmeh mentioned this pull request Apr 16, 2025
Closed
@mui-bot
Copy link

mui-bot commented Apr 16, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-17394--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2298973

@arminmeh arminmeh marked this pull request as draft April 16, 2025 09:39
@arminmeh arminmeh removed the request for review from a team April 16, 2025 09:39
@arminmeh arminmeh force-pushed the fix-master-detail-dynamic-row branch 2 times, most recently from ab9e954 to ba3cd0a Compare April 22, 2025 08:35
@arminmeh arminmeh force-pushed the fix-master-detail-dynamic-row branch from ba3cd0a to 78975f4 Compare April 22, 2025 09:06
@arminmeh arminmeh marked this pull request as ready for review April 22, 2025 09:06
@arminmeh arminmeh requested a review from a team April 22, 2025 09:06
@arminmeh arminmeh enabled auto-merge (squash) April 22, 2025 10:45
@arminmeh arminmeh disabled auto-merge April 22, 2025 13:13
@arminmeh arminmeh merged commit f2a0bfa into mui:master Apr 23, 2025
21 checks passed
@arminmeh arminmeh deleted the fix-master-detail-dynamic-row branch April 23, 2025 06:50
@github-actions GitHub Actions
Copy link

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Apr 23, 2025
@arminmeh @web-flow
[DataGridPro] Fix expandable rows detail content height updates (#17394)
cafa7b4
@github-actions github-actions bot mentioned this pull request Apr 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Master-detail Related to the data grid Master-detail feature needs cherry-pick The PR should be cherry-picked to master after merge plan: Pro Impact at least one Pro user v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Expandable rows detail content height is not getting updated
3 participants
@arminmeh @mui-bot @cherniavskii