Fixed pylint issues

Author: muizabdul29

pybatteryid/inputdesign.py

@@ -27,7 +27,7 @@ def generate_rectangular_pulse_train(pulse_periods):
     return pulse_train
 
 
-# pylint: disable=too-many-locals, too-many-arguments
+# pylint: disable=too-many-locals, too-many-arguments, R0917
 def generate_current_profile(mean_pulse_period: float,
                              std_pulse_period: float,
                              mean_rest_period: float,

pybatteryid/modelstructure.py

@@ -180,7 +180,7 @@ def setup_regression_problems(self, datasets: list[CurrentVoltageData],
         return regression_problems, regressor_labels
 
 
-    # pylint: disable=too-many-arguments
+    # pylint: disable=too-many-arguments, R0917
     def identify(self, datasets: list[CurrentVoltageData] | CurrentVoltageData,
                  model_order: int, nonlinearity_order: int,
                  optimizers: Literal['lasso.cvxopt', 'lasso.sklearn', 'ridge.sklearn'],

pybatteryid/plotter.py

@@ -8,7 +8,7 @@
 from matplotlib.axes import Axes
 
 
-# pylint: disable=too-many-locals, too-many-arguments
+# pylint: disable=too-many-locals, too-many-arguments, R0917
 def plot_custom(x_y_data_tuples: list[Tuple], figsize: Tuple[int, int]=(10, 3),
                 xlabel: str='x', ylabel: str='y', legends: list[str]|None=None,
                 linestyles: list[str]|None=None, xaxis_reverse: bool=False,
@@ -58,6 +58,7 @@ def plot_custom(x_y_data_tuples: list[Tuple], figsize: Tuple[int, int]=(10, 3),
     plt.show()
 
 
+# pylint: disable=R0917
 def plot_time_vs_voltage(time_voltage_data_tuples: list[Tuple], figsize: Tuple[int, int]=(6, 2),
                          legends: list[str]|None=None, linestyles: list[str]|None=None,
                          linewidth: float|None=None, units: Tuple[str, str]=('sec', 'V'),
@@ -70,6 +71,7 @@ def plot_time_vs_voltage(time_voltage_data_tuples: list[Tuple], figsize: Tuple[i
         linewidth=linewidth, xlims=xlims, ylims=ylims, colors=colors)
 
 
+# pylint: disable=R0917
 def plot_time_vs_current(time_current_data_tuples: list[Tuple], figsize: Tuple[int, int]=(6, 2),
                          legends: list[str]|None=None, linestyles: list[str]|None=None,
                          linewidth: float|None=None, units: Tuple[str, str]=('sec', 'A'),
@@ -82,6 +84,7 @@ def plot_time_vs_current(time_current_data_tuples: list[Tuple], figsize: Tuple[i
                 ylims=ylims, xlims=xlims, linewidth=linewidth, colors=colors)
 
 
+# pylint: disable=R0917
 def plot_time_vs_temperature(time_temperature_data_tuples: list[Tuple],
                              figsize: Tuple[int, int]=(6, 2), legends: list[str]|None=None,
                              linestyles: list[str]|None=None, linewidth: float|None=None,

pybatteryid/utilities.py

@@ -9,7 +9,7 @@
 
 from scipy.integrate import trapezoid
 from scipy.optimize import minimize_scalar
-from scipy.spatial import ConvexHull
+from scipy.spatial import ConvexHull # pylint: disable=E0611
 from rich.jupyter import print as rich_print
 from rich.table import Table
 
@@ -19,6 +19,7 @@
 from .plotter import plot_custom
 
 
+# pylint: disable=too-many-locals
 def analyze_temperature_soc_space(datasets: list[CurrentVoltageData], battery_capacity: float,
                                   sampling_period: float, emf_function: VoltageFunction,
                                   hysteresis_function: VoltageFunction | None = None):
@@ -58,6 +59,7 @@ def _function(soc: float):
     return minimize_scalar(_function, bounds=(0, 1)).x
 
 
+# pylint: disable=too-many-locals, too-many-arguments, R0917
 def analyze_dataset(dataset: CurrentVoltageData, battery_capacity: float,
                     sampling_period: float, emf_function: VoltageFunction,
                     hysteresis_function: VoltageFunction | None = None,

setup.py

@@ -1,5 +1,6 @@
 """Setup for the PyBatteryID package"""
 
+# pylint: disable=E0401
 from setuptools import setup, find_packages
 
 with open("README.md", encoding="utf-8") as f:

tests/test_basis_functions_operation.py

@@ -74,7 +74,7 @@ def test_exp_sqrt_abs_operation(scheduling_signals: SignalVector):
 def test_exp_pow_abs_operation(scheduling_signals: SignalVector):
     """Exponential arbitrary power operation."""
 
-    T = scheduling_signals.find('T')
+    T = scheduling_signals.find('T') # pylint: disable=C0103
     i = scheduling_signals.find('i')
     #
     strings = ['exp[[0.00366*T+1]^-1]', 'exp[-2.759*[|-1.5*i+1890|]^+2.89]']