-
Notifications
You must be signed in to change notification settings - Fork 41
Description
On some sites, vaultPass does not correctly find the username and/or password inputs to add the saved data to.
Provide inputSelector.username and inputSelector.password (or equivalent) vault data items that if present are used (and preferably prioritized) as additional query selectors in the findPasswordInput() and findUsernameNodeIn() functions in content.js. This likely means sending it as an additional item through the fill_creds message sent inthe extension.
Other than continuously adding additional selectors that are attempted for the username, I'm not sure of how to handle sites automatically that don't meet current expectations for what forms a username input can take. Manual copy and paste works, so this isn't a change required to fix the plugin from being non-functional, but it would be a nice quality of life improvement.
Whether to allow this for the password entry is slightly more complex of a problem, as allowing the password to automatically be entered into a non-password type input and have it visible may be a security regression not worth doing. Even so, I think the username field is in my experience the one more likely to need this help, so not supporting the password input in this way doesn't negate the usefulness of this suggestion entirely.