Skip to content

Commit a95fb52

Browse files
committed
Correct successful to success
According to [this documentation][1], I should've written `success` instead of `successful`, and this is also double-checked by querying the API: ```sh curl -SsfL -H @headers $GITHUB_API | jq '{ state, conclusion }' { "state": null, "conclusion": "success" } ``` [1]: https://archive.is/4IM5j#check-statuses-and-conclusions
1 parent ebf5a0f commit a95fb52

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

.github/workflows/ios-end-to-end-tests-nightly-notification.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@ jobs:
1313
notify-on-failed-workflow:
1414
# Payload of workflow_run:
1515
# https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2026-03-10#get-a-workflow-run
16-
if: "${{ github.event.workflow_run.conclusion != 'successful' }}"
16+
#
17+
# Valid values for conclusion are listed on:
18+
# https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks#check-statuses-and-conclusions
19+
if: "${{ github.event.workflow_run.conclusion != 'success' }}"
1720
name: Notify team on nightly E2E failure
1821
runs-on: [ubuntu-latest]
1922
timeout-minutes: 5

0 commit comments

Comments
 (0)