Skip to content

Commit 1a64919

Browse files
authored
fix: Comments after an Approval break approval (#17)
1 parent 31c1dce commit 1a64919

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

.codeowners

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# For now, Hans reviews everything
2-
* @BakerNet
3-
codeowners.toml @zbedforrest
2+
* @BakerNet @zbedforrest

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Code Ownership & Review Assignment Tool - GitHub CODEOWNERS but better
44

55
[![Go Report Card](https://goreportcard.com/badge/github.com/multimediallc/codeowners-plus)](https://goreportcard.com/report/github.com/multimediallc/codeowners-plus?kill_cache=1)
66
[![Tests](https://github.com/multimediallc/codeowners-plus/actions/workflows/go.yml/badge.svg)](https://github.com/multimediallc/codeowners-plus/actions/workflows/go.yml)
7-
![Coverage](https://img.shields.io/badge/Coverage-83.0%25-brightgreen)
7+
![Coverage](https://img.shields.io/badge/Coverage-83.1%25-brightgreen)
88
[![License](https://img.shields.io/badge/License-BSD%203--Clause-blue.svg)](https://opensource.org/licenses/BSD-3-Clause)
99
[![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-2.1-4baaaa.svg)](CODE_OF_CONDUCT.md)
1010

internal/github/gh.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ func (gh *GHClient) approvals() []*github.PullRequestReview {
162162
if _, ok := seen[userName]; ok {
163163
// we only care about the most recent reviews for each user
164164
return false
165-
} else {
165+
} else if approval.GetState() == "APPROVED" {
166166
seen[userName] = true
167167
}
168168
return approval.GetState() == "APPROVED"

0 commit comments

Comments
 (0)