Skip to content

Commit 25c7bd9

Browse files
authored
fix: non-owner reviews not counting toward min reviews (#21)
1 parent 066547e commit 25c7bd9

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

internal/github/gh.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -228,6 +228,9 @@ func currentReviewerApprovalsFromReviews(approvals []*github.PullRequestReview,
228228
if reviewers, ok := userReviewerMap[reviewingUser]; ok {
229229
newApproval := &CurrentApproval{reviewingUser, review.GetID(), reviewers, review.GetCommitID()}
230230
filteredApprovals = append(filteredApprovals, newApproval)
231+
} else {
232+
newApproval := &CurrentApproval{reviewingUser, review.GetID(), []string{}, review.GetCommitID()}
233+
filteredApprovals = append(filteredApprovals, newApproval)
231234
}
232235
}
233236

internal/github/gh_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ func TestCurrentApprovalsFromReviews(t *testing.T) {
7272
expectedApprovals := []*CurrentApproval{
7373
{CommitID: "commit1", Reviewers: []string{"@a", "@b"}},
7474
{CommitID: "commit3", Reviewers: []string{"@e"}},
75+
{CommitID: "commit3", Reviewers: []string{}},
7576
}
7677

7778
if len(currentApprovals) != len(expectedApprovals) {

0 commit comments

Comments
 (0)