Skip to content

Commit 6425a94

Browse files
committed
Bugfix - approvals not being applied for PRs with no diff since review
1 parent a5c88a3 commit 6425a94

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Code Ownership & Review Assignment Tool - GitHub CODEOWNERS but better
44

55
[![Go Report Card](https://goreportcard.com/badge/github.com/multimediallc/codeowners-plus)](https://goreportcard.com/report/github.com/multimediallc/codeowners-plus?kill_cache=1)
66
[![Tests](https://github.com/multimediallc/codeowners-plus/actions/workflows/go.yml/badge.svg)](https://github.com/multimediallc/codeowners-plus/actions/workflows/go.yml)
7-
![Coverage](https://img.shields.io/badge/Coverage-59.8%25-yellow)
7+
![Coverage](https://img.shields.io/badge/Coverage-59.9%25-yellow)
88
[![License](https://img.shields.io/badge/License-BSD%203--Clause-blue.svg)](https://opensource.org/licenses/BSD-3-Clause)
99
[![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-2.1-4baaaa.svg)](CODE_OF_CONDUCT.md)
1010

internal/github/approvals.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,6 @@ func checkStale(
6060
// for each file in the changes since approval
6161
// if the file is owned by the approval owner, mark stale
6262
// else, mark all overlapping owners as satisfied
63-
if len(approval.Diff) == 0 {
64-
continue
65-
}
6663
stale := false
6764
for _, diffFile := range approval.Diff {
6865
fileOwners, ok := fileReviewerMap[diffFile.FileName]

0 commit comments

Comments
 (0)