Skip to content

Switch to docker image for Codeowners Plus #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BakerNet merged 2 commits into from
Mar 5, 2025
Merged

Switch to docker image for Codeowners Plus #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93ecd14
v0.1 action.yml
BakerNet Mar 4, 2025
c3decd8
main use latest
BakerNet Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: 'Build & Publish'
uses: elgohr/Publish-Docker-Github-Action@eb53b3ec07136a6ebaed78d8135806da64f7c7e2 # v5
with:
name: multimediallc/mm-codeowners
name: multimediallc/codeowners-plus
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}
registry: ghcr.io
Expand Down
3 changes: 1 addition & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,4 @@ inputs:

runs:
using: 'docker'
# image: 'docker://ghcr.io/multimediallc/mm-codeowners:v0.1.0' # uncomment for v0.1 release
image: 'Dockerfile'
image: 'docker://ghcr.io/multimediallc/codeowners-plus:latest'
2 changes: 1 addition & 1 deletion pkg/codeowners/codeowners_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ func TestGetOwnersFail(t *testing.T) {
rgMan := NewReviewerGroupMemo()
tree := initOwnerTreeNode("../../test_project", "../../test_project", rgMan, nil, io.Discard)
testMap := tree.BuildFromFiles(files, rgMan)
files = append(files, "non_existant_file")
files = append(files, "non_existent_file")
_, err := testMap.getOwners(files)
if err == nil {
t.Errorf("Expected error getting owners: %v", err)
Expand Down