fix: Comments after an Approval break approval #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbedforrest
previously approved these changes
Mar 22, 2025
BakerNet
force-pushed
the
fix/comment-breaking-approval
branch
from
9d7c7b0 to
c9a4ed8
Compare
|
Codeowners approval required for this PR: |
github-actions
bot
dismissed
zbedforrest’s stale review
Changes in owned files since last approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary / Background
A bug was reported where an approval was not being counted. The approval filtering currently only counts the last review, not the last approval - because issue comments count as reviews, this was resulting in a comment after an approval causing the approval to not be counted.