From a54500ed495ecbc2cb59f4872a63e17d698a75ed Mon Sep 17 00:00:00 2001 From: BakerNet Date: Fri, 21 Mar 2025 13:42:49 -0700 Subject: [PATCH 1/3] Fix issue where Comments after an approval are resultingin approval not being counted --- internal/github/gh.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/github/gh.go b/internal/github/gh.go index ef77ec2..90f0dfe 100644 --- a/internal/github/gh.go +++ b/internal/github/gh.go @@ -162,7 +162,7 @@ func (gh *GHClient) approvals() []*github.PullRequestReview { if _, ok := seen[userName]; ok { // we only care about the most recent reviews for each user return false - } else { + } else if approval.GetState() == "APPROVED" { seen[userName] = true } return approval.GetState() == "APPROVED" From c9a4ed8c603e133a72115c4443203d90aac8f6a6 Mon Sep 17 00:00:00 2001 From: BakerNet Date: Tue, 25 Mar 2025 11:52:09 -0700 Subject: [PATCH 2/3] Change codeowners --- .codeowners | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.codeowners b/.codeowners index 75c73be..9cb0383 100644 --- a/.codeowners +++ b/.codeowners @@ -1,3 +1,2 @@ # For now, Hans reviews everything -* @BakerNet -codeowners.toml @zbedforrest +* @BakerNet @zbedforrest From ba704ae88c7b7d678c9550cb8f59f14076fd4206 Mon Sep 17 00:00:00 2001 From: BakerNet Date: Tue, 25 Mar 2025 12:09:05 -0700 Subject: [PATCH 3/3] covbadge --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b80807b..328cd1c 100644 --- a/README.md +++ b/README.md @@ -4,7 +4,7 @@ Code Ownership & Review Assignment Tool - GitHub CODEOWNERS but better [![Go Report Card](https://goreportcard.com/badge/github.com/multimediallc/codeowners-plus)](https://goreportcard.com/report/github.com/multimediallc/codeowners-plus?kill_cache=1) [![Tests](https://github.com/multimediallc/codeowners-plus/actions/workflows/go.yml/badge.svg)](https://github.com/multimediallc/codeowners-plus/actions/workflows/go.yml) -![Coverage](https://img.shields.io/badge/Coverage-83.0%25-brightgreen) +![Coverage](https://img.shields.io/badge/Coverage-83.1%25-brightgreen) [![License](https://img.shields.io/badge/License-BSD%203--Clause-blue.svg)](https://opensource.org/licenses/BSD-3-Clause) [![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-2.1-4baaaa.svg)](CODE_OF_CONDUCT.md)