Skip to content

fix: Comments after an Approval break approval #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BakerNet merged 3 commits into from
Mar 25, 2025
Merged

fix: Comments after an Approval break approval #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a54500e
Fix issue where Comments after an approval are resultingin approval not
BakerNet Mar 21, 2025
c9a4ed8
Change codeowners
BakerNet Mar 25, 2025
ba704ae
covbadge
BakerNet Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .codeowners
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
# For now, Hans reviews everything
* @BakerNet
codeowners.toml @zbedforrest
* @BakerNet @zbedforrest
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Code Ownership & Review Assignment Tool - GitHub CODEOWNERS but better

[![Go Report Card](https://goreportcard.com/badge/github.com/multimediallc/codeowners-plus)](https://goreportcard.com/report/github.com/multimediallc/codeowners-plus?kill_cache=1)
[![Tests](https://github.com/multimediallc/codeowners-plus/actions/workflows/go.yml/badge.svg)](https://github.com/multimediallc/codeowners-plus/actions/workflows/go.yml)
![Coverage](https://img.shields.io/badge/Coverage-83.0%25-brightgreen)
![Coverage](https://img.shields.io/badge/Coverage-83.1%25-brightgreen)
[![License](https://img.shields.io/badge/License-BSD%203--Clause-blue.svg)](https://opensource.org/licenses/BSD-3-Clause)
[![Contributor Covenant](https://img.shields.io/badge/Contributor%20Covenant-2.1-4baaaa.svg)](CODE_OF_CONDUCT.md)

Expand Down
2 changes: 1 addition & 1 deletion internal/github/gh.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ func (gh *GHClient) approvals() []*github.PullRequestReview {
if _, ok := seen[userName]; ok {
// we only care about the most recent reviews for each user
return false
} else {
} else if approval.GetState() == "APPROVED" {
seen[userName] = true
}
return approval.GetState() == "APPROVED"
Expand Down