Add owners for deleted files

[BakerNet]

Related Issue(s)

Closes #69

Summary / Background

Currently, deleted files are essentially ignored by Codeowners Plus. This PR makes it so the old filename is used when a file is deleted for the purpose of assigning owners.

[pooyaw]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

✅ license/snyk check is complete. No issues have been found. (View Details)

[gemini-code-assist]

Summary of Changes

Hello @BakerNet, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a gap in Codeowners Plus by implementing robust handling for deleted files. Previously, deleted files were not properly considered during the owner assignment process. The changes ensure that the original filename of a deleted file is used to determine its owners, and that ignored directories are correctly applied to these deletions, leading to a more comprehensive and accurate code ownership system.

Highlights

• Deleted File Ownership: Codeowners Plus now correctly identifies deleted files by their original filename, ensuring that ownership rules are applied even when files are removed.
• Ignored Directories for Deletions: The system now properly respects ignored directories for deleted files, preventing them from being processed if they reside within a configured ignored path.
• Enhanced Test Coverage: New unit tests have been added to validate the accurate handling of deleted files, including scenarios involving ignored directories and mixed file changes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Codeowners approval required for this PR:

• @zbedforrest

[gemini-code-assist]

Code Review

This pull request correctly extends functionality to handle deleted files by using their original path for owner assignment. The changes are implemented across toDiffFiles, changesSince, and getGitDiff. I've found a critical bug in the changesSince function where a file path is incorrectly sliced. I've also suggested a small refactoring to deduplicate the logic for determining file names, which would improve maintainability. The added tests are good but are missing coverage for deleted files in the changesSince function, which is where the bug is.