-
Notifications
You must be signed in to change notification settings - Fork 7
v1.5.0 #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.5.0 #71
Conversation
Summary of ChangesHello @BakerNet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating version numbers across the project. It ensures that the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
|
Codeowners approval required for this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the version numbers for the v1.5.0 release. The change in README.md correctly updates the recommended action version. However, I've noted a potential inconsistency in the CLI versioning in tools/cli/main.go. My feedback suggests aligning the CLI version with the release version for better clarity and consistency in the release process.
| Name: "codeowners-cli", | ||
| Usage: "CLI tool for working with .codeowners files", | ||
| Version: "v1.3.3.dev", | ||
| Version: "v1.5.1.dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR appears to be for the v1.5.0 release. Setting the CLI version to v1.5.1.dev in this PR means that the binary built from the v1.5.0 tag will report its version as v1.5.1.dev, which could be confusing for users.
A common practice is to set the version to the actual release number in the release commit. A follow-up PR can then bump it to the next development version. I'd suggest setting the version to v1.5.0 here.
| Version: "v1.5.1.dev", | |
| Version: "v1.5.0", |
Summary / Background
Post v1.5.0