-
Notifications
You must be signed in to change notification settings - Fork 7
v1.6.0 #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v1.6.0 #79
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Summary of ChangesHello @BakerNet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating version numbers across the project. It updates the reference to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Codeowners approval required for this PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request appears to be a post-release version bump for v1.6.0. The changes update the version in the README.md to point to the new v1.6.0 release and update the CLI tool's version for the next development cycle. I've identified a minor issue with the format of the new development version string. For better clarity in the future, consider making the PR title and description more descriptive, for example, 'Post-release: Bump version to v1.6.1.dev'.
| Name: "codeowners-cli", | ||
| Usage: "CLI tool for working with .codeowners files", | ||
| Version: "v1.5.1.dev", | ||
| Version: "v1.6.1.dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new development version string v1.6.1.dev appears to be malformed. It should likely be v1.6.1.dev. This seems to be caused by a bug in the post-release.sh script, which incorrectly parses the version tag by including the 'v' prefix as part of the major version number. While fixing the script is outside the scope of this PR's changes, correcting the version string here is recommended. You should also consider fixing the script to prevent this from happening in future releases.
| Version: "v1.6.1.dev", | |
| Version: "v1.6.1.dev", |
Related PR(s)
Related Issue(s)
Summary / Background