Skip to content

Commit 2502205

Browse files
authored
Fix broken CI by patching GitHub Actions back to vs2022 (#4607)
Visual Studio 2026 isn't ready on GitHub Actions, so [the upgrade to 2026](c757a89) around [this time period](https://github.com/multitheftauto/mtasa-blue/commits/master/?after=1c590fbc46884bb25809d85d1017c08f779c6a28+104) causes GitHub Actions builds to stop succeeding. Since we can't upgrade to Visual Studio 2026 yet (actions/runner-images#13291), this change temporarily restores VS 2022 just for the purpose of CI. Additionally this change clarifies how to install MFC v145, since the text has changed in the Visual Studio installer. **Test plan** CI should pass **Safe to revert?** Yes
1 parent 1c590fb commit 2502205

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

.github/workflows/build.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,13 @@ jobs:
2929
run: Expand-Archive -Path utils/DXFiles.zip -DestinationPath utils/DXFiles
3030
shell: powershell
3131

32+
- name: Restore vs2022
33+
run: |
34+
git fetch origin c757a89f7c92fa7c814572b28384ca5985fff5bb
35+
git checkout c757a89f7c92fa7c814572b28384ca5985fff5bb -- README.md
36+
git revert c757a89f7c92fa7c814572b28384ca5985fff5bb --no-commit
37+
shell: bash
38+
3239
- name: Install CEF
3340
run: utils\premake5 install_cef
3441

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Our project's code repository can be found on the [multitheftauto/mtasa-blue](ht
3737
Prerequisites
3838
- [Visual Studio 2026](https://visualstudio.microsoft.com/vs/) with:
3939
- Desktop development with C++
40-
- Optional component *C++ MFC for latest v145 build tools (x86 & x64)*
40+
- Optional component *C++ MFC for latest v145 build tools (x86 & x64)* or if that's missing *C++ MFC for x64/x86 (Latest MSVC)*
4141
- [Microsoft DirectX SDK](https://wiki.multitheftauto.com/wiki/Compiling_MTASA#Microsoft_DirectX_SDK)
4242
- [Git for Windows](https://git-scm.com/download/win) (Optional)
4343

0 commit comments

Comments
 (0)