Commit 95e0752
authored
Fix client-side createExplosion ignoring makeSound and camShake parameters (#4869)
#### Summary
Make client-side `createExplosion` honour the `makeSound` and `camShake`
arguments again.
#### Motivation
User report: since 1.7, client `createExplosion(..., makeSound,
camShake, ...)` ignores those parameters; explosions always play sound
and shake the camera with default strength.
Caused by #4341, which routed script-driven explosions through a path
that re-broadcasts them via the server and drops the script's arguments
along the way.
#### Test plan
- `makeSound=false, camShake=0`: silent, no shake.
- `makeSound=true, camShake=1.5`: sound + brief shake.
- server API (no sound/shake params): unchanged -- still has sound +
shake.
Engine-side explosions (grenades, rockets, vehicle blow-ups) behave
unchanged.
#### Checklist
* [x] Your code should follow the [coding
guidelines](https://wiki.multitheftauto.com/index.php?title=Coding_guidelines).
* [x] Smaller pull requests are easier to review. If your pull request
is beefy, your pull request should be reviewable commit-by-commit.1 parent 9e1a38c commit 95e0752
1 file changed
Lines changed: 11 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
214 | 219 | | |
215 | 220 | | |
216 | 221 | | |
217 | | - | |
218 | | - | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
219 | 228 | | |
220 | 229 | | |
221 | 230 | | |
| |||
0 commit comments