Remove dead code.

Author: andreibancioiu

server/services/transactionsFeaturesDetector.go

@@ -77,21 +77,6 @@ func (detector *transactionsFeaturesDetector) isInvalidTransactionOfTypeMoveBala
 	return withSendingValueToNonPayableContract || withMetaTransactionIsInvalid
 }
 
-func (detector *transactionsFeaturesDetector) isRelayedV1TransactionCompletelyIntrashardWithSignalError(tx *transaction.ApiTransactionResult, innerTx *innerTransactionOfRelayedV1) bool {
-	innerTxSenderShard := detector.networkProvider.ComputeShardIdOfPubKey(innerTx.SenderPubKey)
-	innerTxReceiverShard := detector.networkProvider.ComputeShardIdOfPubKey(innerTx.ReceiverPubKey)
-
-	isCompletelyIntrashard := tx.SourceShard == tx.DestinationShard &&
-		innerTxSenderShard == innerTxReceiverShard &&
-		innerTxSenderShard == tx.SourceShard
-	if !isCompletelyIntrashard {
-		return false
-	}
-
-	isWithSignalError := detector.eventsController.hasAnySignalError(tx)
-	return isWithSignalError
-}
-
 func (detector *transactionsFeaturesDetector) isContractDeploymentWithSignalErrorOrIntrashardContractCallWithSignalError(tx *transaction.ApiTransactionResult) bool {
 	return detector.isContractDeploymentWithSignalError(tx) || (detector.isIntrashard(tx) && detector.isContractCallWithSignalError(tx))
 }

server/services/transactionsFeaturesDetector_test.go

@@ -75,63 +75,6 @@ func TestTransactionsFeaturesDetector_IsInvalidTransactionOfTypeMoveBalanceThatO
 	})
 }
 
-func TestTransactionsFeaturesDetector_isRelayedV1TransactionCompletelyIntrashardWithSignalError(t *testing.T) {
-	networkProvider := testscommon.NewNetworkProviderMock()
-	detector := newTransactionsFeaturesDetector(networkProvider)
-
-	t.Run("arbitrary relayed tx", func(t *testing.T) {
-		tx := &transaction.ApiTransactionResult{
-			SourceShard:      0,
-			DestinationShard: 1,
-		}
-
-		innerTx := &innerTransactionOfRelayedV1{
-			SenderPubKey:   testscommon.TestUserShard1.PubKey,
-			ReceiverPubKey: testscommon.TestUserShard2.PubKey,
-		}
-
-		featureDetected := detector.isRelayedV1TransactionCompletelyIntrashardWithSignalError(tx, innerTx)
-		require.False(t, featureDetected)
-	})
-
-	t.Run("completely intrashard relayed tx, but no signal error", func(t *testing.T) {
-		tx := &transaction.ApiTransactionResult{
-			SourceShard:      0,
-			DestinationShard: 0,
-		}
-
-		innerTx := &innerTransactionOfRelayedV1{
-			SenderPubKey:   testscommon.TestUserAShard0.PubKey,
-			ReceiverPubKey: testscommon.TestUserBShard0.PubKey,
-		}
-
-		featureDetected := detector.isRelayedV1TransactionCompletelyIntrashardWithSignalError(tx, innerTx)
-		require.False(t, featureDetected)
-	})
-
-	t.Run("completely intrashard relayed tx, with signal error", func(t *testing.T) {
-		tx := &transaction.ApiTransactionResult{
-			SourceShard:      0,
-			DestinationShard: 0,
-			Logs: &transaction.ApiLogs{
-				Events: []*transaction.Events{
-					{
-						Identifier: transactionEventSignalError,
-					},
-				},
-			},
-		}
-
-		innerTx := &innerTransactionOfRelayedV1{
-			SenderPubKey:   testscommon.TestUserAShard0.PubKey,
-			ReceiverPubKey: testscommon.TestUserBShard0.PubKey,
-		}
-
-		featureDetected := detector.isRelayedV1TransactionCompletelyIntrashardWithSignalError(tx, innerTx)
-		require.True(t, featureDetected)
-	})
-}
-
 func TestTransactionsFeatureDetector_isContractDeploymentWithSignalErrorOrIntrashardContractCallWithSignalError(t *testing.T) {
 	networkProvider := testscommon.NewNetworkProviderMock()
 	detector := newTransactionsFeaturesDetector(networkProvider)