From d1e30460ce22a8d893091f6ef6372aee50f32e7e Mon Sep 17 00:00:00 2001 From: Gavrila Andrei Date: Wed, 12 Nov 2025 09:56:26 +0200 Subject: [PATCH 1/4] Added skip tests on draft PR --- .github/workflows/changelog.yml | 7 ++++--- .github/workflows/pre-merge-unit-tests.yml | 2 ++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/changelog.yml b/.github/workflows/changelog.yml index 1b1502a2..62b05735 100644 --- a/.github/workflows/changelog.yml +++ b/.github/workflows/changelog.yml @@ -1,4 +1,4 @@ -name: "CHANGELOG entry secretary" +name: 'CHANGELOG entry secretary' on: pull_request: branches: [main, development] @@ -9,8 +9,9 @@ on: types: [opened, synchronize, reopened, ready_for_review, labeled, unlabeled] jobs: - # Enforces the update of a changelog file on every pull request + # Enforces the update of a changelog file on every pull request changelog: runs-on: ubuntu-latest + if: ${{ !github.event.pull_request.draft }} steps: - - uses: dangoslen/changelog-enforcer@v3 \ No newline at end of file + - uses: dangoslen/changelog-enforcer@v3 diff --git a/.github/workflows/pre-merge-unit-tests.yml b/.github/workflows/pre-merge-unit-tests.yml index 8f425221..eac7af96 100644 --- a/.github/workflows/pre-merge-unit-tests.yml +++ b/.github/workflows/pre-merge-unit-tests.yml @@ -1,6 +1,7 @@ name: 'Stencil Unit Tests' on: pull_request: + types: [opened, synchronize, reopened, ready_for_review] branches: [main, development] paths: - 'src/**' @@ -18,6 +19,7 @@ concurrency: jobs: run-unit-tests: runs-on: ubuntu-latest + if: ${{ !github.event.pull_request.draft }} steps: - name: Fix permissions run: | From adb3cc69740091fab61cb825119ac14a19415772 Mon Sep 17 00:00:00 2001 From: Gavrila Andrei Date: Wed, 12 Nov 2025 09:57:26 +0200 Subject: [PATCH 2/4] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4a8e607c..8c888bd7 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +- [Added skip tests if PR is in draft](https://github.com/multiversx/mx-sdk-dapp-ui/pull/265) - [Added github release on publish](https://github.com/multiversx/mx-sdk-dapp-ui/pull/264) ## [[0.1.2](https://github.com/multiversx/mx-sdk-dapp-ui/pull/263)] - 2025-11-06 From 8379e0a6260e8c832a2393cae4b2815ea54a22ce Mon Sep 17 00:00:00 2001 From: Gavrila Andrei Date: Wed, 12 Nov 2025 09:58:02 +0200 Subject: [PATCH 3/4] Add test log --- src/components/functional/toasts-list/toast-list.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/functional/toasts-list/toast-list.tsx b/src/components/functional/toasts-list/toast-list.tsx index 0e786b0a..e8a3b6b0 100644 --- a/src/components/functional/toasts-list/toast-list.tsx +++ b/src/components/functional/toasts-list/toast-list.tsx @@ -43,6 +43,7 @@ export class ToastList { } disconnectedCallback() { + console.log('test'); this.resetState(); this.unsubscribeFunctions.forEach(unsubscribe => { if (typeof unsubscribe === 'function') { From 8e8d2ffeed9a3ba1e99a68f4424b20022b6251dd Mon Sep 17 00:00:00 2001 From: Gavrila Andrei Date: Wed, 12 Nov 2025 10:00:37 +0200 Subject: [PATCH 4/4] Remove log --- src/components/functional/toasts-list/toast-list.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/functional/toasts-list/toast-list.tsx b/src/components/functional/toasts-list/toast-list.tsx index e8a3b6b0..0e786b0a 100644 --- a/src/components/functional/toasts-list/toast-list.tsx +++ b/src/components/functional/toasts-list/toast-list.tsx @@ -43,7 +43,6 @@ export class ToastList { } disconnectedCallback() { - console.log('test'); this.resetState(); this.unsubscribeFunctions.forEach(unsubscribe => { if (typeof unsubscribe === 'function') {