Skip to content

Commit 0323218

Browse files
committed
Deprecate PagedListHolder and PropertyComparator for removal
Closes spring-projectsgh-36139
1 parent a62699c commit 0323218

6 files changed

Lines changed: 19 additions & 3 deletions

File tree

spring-beans/src/main/java/org/springframework/beans/support/MutableSortDefinition.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,11 @@
3030
* @author Jean-Pierre Pawlak
3131
* @since 26.05.2003
3232
* @see #setToggleAscendingOnProperty
33+
* @deprecated as severely outdated and superseded by more modern solutions,
34+
* for example in Spring Data Commons
3335
*/
34-
@SuppressWarnings("serial")
36+
@Deprecated(since = "7.0.3", forRemoval = true)
37+
@SuppressWarnings({"removal", "serial"})
3538
public class MutableSortDefinition implements SortDefinition, Serializable {
3639

3740
private String property = "";

spring-beans/src/main/java/org/springframework/beans/support/PagedListHolder.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,11 @@
4949
* @since 19.05.2003
5050
* @param <E> the element type
5151
* @see #getPageList()
52-
* @see org.springframework.beans.support.MutableSortDefinition
52+
* @deprecated as severely outdated and superseded by more modern solutions,
53+
* for example in Spring Data Commons
5354
*/
54-
@SuppressWarnings("serial")
55+
@Deprecated(since = "7.0.3", forRemoval = true)
56+
@SuppressWarnings({"removal", "serial"})
5557
public class PagedListHolder<E> implements Serializable {
5658

5759
/**

spring-beans/src/main/java/org/springframework/beans/support/PropertyComparator.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,11 @@
3838
* @since 19.05.2003
3939
* @param <T> the type of objects that may be compared by this comparator
4040
* @see org.springframework.beans.BeanWrapper
41+
* @deprecated as severely outdated and superseded by more modern solutions,
42+
* for example in Spring Data Commons
4143
*/
44+
@Deprecated(since = "7.0.3", forRemoval = true)
45+
@SuppressWarnings("removal")
4246
public class PropertyComparator<T> implements Comparator<T> {
4347

4448
protected final Log logger = LogFactory.getLog(getClass());

spring-beans/src/main/java/org/springframework/beans/support/SortDefinition.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@
2121
*
2222
* @author Juergen Hoeller
2323
* @since 26.05.2003
24+
* @deprecated as severely outdated and superseded by more modern solutions,
25+
* for example in Spring Data Commons
2426
*/
27+
@Deprecated(since = "7.0.3", forRemoval = true)
2528
public interface SortDefinition {
2629

2730
/**

spring-beans/src/test/java/org/springframework/beans/support/PagedListHolderTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,8 @@
3232
* @author Chris Beams
3333
* @since 20.05.2003
3434
*/
35+
@Deprecated(since = "7.0.3", forRemoval = true)
36+
@SuppressWarnings("removal")
3537
class PagedListHolderTests {
3638

3739
@Test

spring-beans/src/test/java/org/springframework/beans/support/PropertyComparatorTests.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,8 @@
2828
* @author Keith Donald
2929
* @author Chris Beams
3030
*/
31+
@Deprecated(since = "7.0.3", forRemoval = true)
32+
@SuppressWarnings("removal")
3133
class PropertyComparatorTests {
3234

3335
@Test

0 commit comments

Comments
 (0)