Updates

Author: mike-spa

src/engraving/dom/guitarbend.cpp

@@ -408,12 +408,17 @@ PropertyValue GuitarBend::propertyDefault(Pid id) const
     case Pid::BEND_SHOW_HOLD_LINE:
         return static_cast<int>(GuitarBendShowHoldLine::AUTO);
     case Pid::BEND_START_TIME_FACTOR:
+        if (m_bendType == GuitarBendType::DIP) {
+            return DIP_DEFAULT_START_TIME_FACTOR;
+        }
         return 0.f;
     case Pid::BEND_END_TIME_FACTOR:
         if (m_bendType == GuitarBendType::GRACE_NOTE_BEND) {
             return GRACE_NOTE_BEND_DEFAULT_END_TIME_FACTOR;
         }
-
+        if (m_bendType == GuitarBendType::DIP) {
+            return DIP_DEFAULT_END_TIME_FACTOR;
+        }
         return 1.f;
     case Pid::GUITAR_DIVE_TAB_POS:
         return DirectionV::AUTO;
@@ -960,9 +965,10 @@ GuitarBendType GuitarBend::bendTypeFromActionIcon(ActionIconType actionIconType)
 void GuitarBend::setBendType(GuitarBendType t)
 {
     m_bendType = t;
-    if (m_bendType == GuitarBendType::DIP) {
-        resetProperty(Pid::GUITAR_BEND_AMOUNT);
-    }
+
+    resetProperty(Pid::GUITAR_BEND_AMOUNT);
+    resetProperty(Pid::BEND_START_TIME_FACTOR);
+    resetProperty(Pid::BEND_END_TIME_FACTOR);
 }
 
 /****************************************

src/engraving/dom/guitarbend.h

@@ -66,6 +66,8 @@ class GuitarBend final : public SLine
 
 public:
     static constexpr float GRACE_NOTE_BEND_DEFAULT_END_TIME_FACTOR = 0.25f;
+    static constexpr float DIP_DEFAULT_START_TIME_FACTOR = 0.25;
+    static constexpr float DIP_DEFAULT_END_TIME_FACTOR = 0.5;
 
     GuitarBend(EngravingItem* parent);
     GuitarBend(const GuitarBend&);

src/engraving/editing/cmd.cpp

@@ -1006,14 +1006,6 @@ GuitarBend* Score::addGuitarBend(GuitarBendType type, Note* note, Note* endNote)
         }
     }
 
-    if (bend->bendType() == GuitarBendType::GRACE_NOTE_BEND) {
-        bend->setEndTimeFactor(GuitarBend::GRACE_NOTE_BEND_DEFAULT_END_TIME_FACTOR);
-    }
-
-    if (bend->bendType() == GuitarBendType::DIP || bend->bendType() == GuitarBendType::SCOOP) {
-        bend->setBendAmountInQuarterTones(-2);
-    }
-
     Chord* startChord = bend->startNote()->chord();
     if (startChord->isGrace()) {
         for (EngravingObject* item : startChord->linkList()) {